On Sun, 2022-07-03 at 13:41 +0200, Paulo Neves wrote:
> bitbake ran but we incorrectly did not assert the exit status needs to
> be non 0. Now all sysroot tests commands expected to fail are verified
> to do so.
> 
> Signed-off-by: Paulo Neves <[email protected]>
> ---
>  meta/lib/oeqa/selftest/cases/sysroot.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta/lib/oeqa/selftest/cases/sysroot.py 
> b/meta/lib/oeqa/selftest/cases/sysroot.py
> index 588fc8c713..294ba4a4a0 100644
> --- a/meta/lib/oeqa/selftest/cases/sysroot.py
> +++ b/meta/lib/oeqa/selftest/cases/sysroot.py
> @@ -45,6 +45,7 @@ TESTSTRING:pn-sysroot-test-arch2 = "%s"
>          expected = "maximum shebang size exceeded, the maximum size is 128. 
> [shebang-size]"
>          res = bitbake("sysroot-shebang-test-native -c populate_sysroot", 
> ignore_status=True)
>          self.assertTrue(expected in res.output, msg=res.output)
> +        self.assertTrue(res.status != 0)
>  
>      def test_sysroot_la(self):
>          """

I did have a question on this patch. Wouldn't it be simpler to remove
the "ignore_status=True" from the bitbake() call?

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#167613): 
https://lists.openembedded.org/g/openembedded-core/message/167613
Mute This Topic: https://lists.openembedded.org/mt/92145212/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to