On 7/13/22 19:53, Richard Purdie wrote:
On Wed, 2022-07-13 at 17:55 +0100, Luca Bocassi wrote:
From: Luca Boccassi <luca.bocca...@microsoft.com>

Ensure it gets tested by the CI

Signed-off-by: Luca Boccassi <luca.bocca...@microsoft.com>
---
  meta-poky/conf/distro/poky-altcfg.conf | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/meta-poky/conf/distro/poky-altcfg.conf 
b/meta-poky/conf/distro/poky-altcfg.conf
index f03306e798..57a76e8bb9 100644
--- a/meta-poky/conf/distro/poky-altcfg.conf
+++ b/meta-poky/conf/distro/poky-altcfg.conf
@@ -9,6 +9,8 @@ DISTROOVERRIDES = "poky:poky-altcfg"
  #DISTROOVERRIDES = "poky:linuxstdbase"
INIT_MANAGER:poky-altcfg = "systemd"
+# systemd will soon require usrmerge
+DISTRO_FEATURES:poky-altcfg += "usrmerge"
  # systemd isn't suitable with musl
  INIT_MANAGER:poky-altcfg:libc-musl = "sysvinit"

This blew up builds since it clears everything else out of
DISTRO_FEATURES which isn't what was intended. I've tweaked the patch
and re-queued.


Maybe I'm missing something, but what is the benefit in introducing and using the "poky-altcfg" override in this file ? If DISTRO_FEATURES was just appended with

DISTRO_FEATURES += "usrmerge"

it would all be fine, since it is after the

require conf/distro/poky.conf

line, right ? And if someone wants to base a distro in "poky-altcfg.conf", they would include "poky-altcfg.conf" first in the same way, then do customizations.

Jacob
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168030): 
https://lists.openembedded.org/g/openembedded-core/message/168030
Mute This Topic: https://lists.openembedded.org/mt/92361983/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to