But looking at the commit that introduced the problem, I see that it
completely undoes it.
In general, I like the idea of having the fstab_updater create the root
entry, but for this to work without duplication, the /dev/root entry
would have to be removed from fstab.
This would force any wic image to use the fstab_updater (which can also
be disabled) and would otherwise result in an fstab file with no root
entry.
Probably removing the /dev/root entry would also break the boot of
images that do not use wic
Translated with www.DeepL.com/Translator (free version)
Am Mi, 27. Jul 2022 um 18:31:38 +0200 schrieb Markus Volk
<[email protected]>:
Yes. With the patch the warning disappears from dmesg
Am Mi, 27. Jul 2022 um 15:44:48 +0000 schrieb Ross Burton
<[email protected]>:
This looks like a fix for
<https://bugzilla.yoctoproject.org/show_bug.cgi?id=14865>, can you
confirm that?
Ross
On 27 Jul 2022, at 14:45, Markus Volk via lists.openembedded.org
<[email protected]
<mailto:[email protected]>> wrote:
We already have a root entry in fstab. This commit prevents
processing root
mountpoint in fstab_updater and thus avoids duplicate entries for
root in fstab.
Signed-off-by: Markus Volk <[email protected]
<mailto:[email protected]>>
---
scripts/lib/wic/plugins/imager/direct.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/lib/wic/plugins/imager/direct.py
b/scripts/lib/wic/plugins/imager/direct.py
index c44159b235..75004ab320 100644
--- a/scripts/lib/wic/plugins/imager/direct.py
+++ b/scripts/lib/wic/plugins/imager/direct.py
@@ -117,7 +117,8 @@ class DirectPlugin(ImagerPlugin):
updated = False
for part in self.parts:
if not part.realnum or not part.mountpoint \
- or not part.mountpoint.startswith('/'):
+ or not part.mountpoint.startswith('/') \
+ or part.mountpoint == "/":
continue
if part.use_uuid:
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168581):
https://lists.openembedded.org/g/openembedded-core/message/168581
Mute This Topic: https://lists.openembedded.org/mt/92649199/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
