On Wed, Jul 27, 2022 at 11:03 PM Khem Raj <[email protected]> wrote:
> > > On 7/27/22 10:51 AM, An?bal Lim?n wrote: > > > > > > On Wed, Jul 27, 2022 at 5:44 AM Luca Ceresoli <[email protected] > > <mailto:[email protected]>> wrote: > > > > Hello Aníbal, > > > > On Tue, 26 Jul 2022 14:33:22 -0500 > > "An?bal Lim?n" <[email protected] > > <mailto:[email protected]>> wrote: > > > > > From: Aníbal Limón <[email protected] > > <mailto:[email protected]>> > > > > > > Change systemd service name from rngd -> rng-tools to avoid load > > twice > > > the service when sysvinit compatibility is enabled, > > > > > > ... > > > root@:~# ps | grep rng > > > 23 root 0 SW [hwrng] > > > 13109 root 3528 R /usr/sbin/rngd -f -r /dev/hwrng > > > 13117 root 2348 S grep rng > > > 29418 root 12756 S /usr/sbin/rngd -r /dev/hwrng > > > ... > > > > > > Signed-off-by: Aníbal Limón <[email protected] > > <mailto:[email protected]>> > > > --- > > > .../rng-tools/{rngd.service => rng-tools.service} | 0 > > > meta/recipes-support/rng-tools/rng-tools_6.15.bb > > <http://rng-tools_6.15.bb> | 12 ++++++------ > > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > rename meta/recipes-support/rng-tools/rng-tools/{rngd.service => > > rng-tools.service} (100%) > > > > > > diff --git > > a/meta/recipes-support/rng-tools/rng-tools/rngd.service > > b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service > > > similarity index 100% > > > rename from meta/recipes-support/rng-tools/rng-tools/rngd.service > > > rename to > meta/recipes-support/rng-tools/rng-tools/rng-tools.service > > > diff --git a/meta/recipes-support/rng-tools/rng-tools_6.15.bb > > <http://rng-tools_6.15.bb> > > b/meta/recipes-support/rng-tools/rng-tools_6.15.bb > > <http://rng-tools_6.15.bb> > > > index 0696351903..efc08b5e0a 100644 > > > --- a/meta/recipes-support/rng-tools/rng-tools_6.15.bb > > <http://rng-tools_6.15.bb> > > > +++ b/meta/recipes-support/rng-tools/rng-tools_6.15.bb > > <http://rng-tools_6.15.bb> > > > @@ -11,7 +11,7 @@ DEPENDS = "sysfsutils openssl" > > > SRC_URI = > > "git://github.com/nhorman/rng-tools.git;branch=master;protocol=https > > < > http://github.com/nhorman/rng-tools.git;branch=master;protocol=https> \ > > > file://init \ > > > file://default \ > > > - file://rngd.service \ > > > + file://rng-tools.service \ > > > > This feels strange to me: "rng-tools" does not look like a daemon > name, > > but rather a, well, tools name. Maybe "rng-daemon" would clarify? > > > > > > Another option is to change the init daemon to be called rngd. > > I think yet another way is to check for condition when sysvinit > compatibility is enabled during install time and decide if we need to > install both sysvinit script and systemd service or not. I do not think > renaming .service file is a good solution here. > I have that solution on the first version of this patch, https://lists.openembedded.org/g/openembedded-core/message/167841?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Acreated%2C0%2Crng-tools%2C20%2C2%2C0%2C92278770 Regards, Anibal > > > > > Regards, > > Anibal > > > > > > Still I'm taking this patch for testing, I'll replace it with v2 > should > > you send one. > > > > However please note there is an extra ']' in the subject: [PATCHv2]] > > should be [PATCHv2]. This leads 'git am' to produce a commit starting > > with a "] " prefix. I fixed it while applying, however you should > check > > that in the future. > > > > Best regards. > > -- > > Luca Ceresoli, Bootlin > > Embedded Linux and Kernel engineering > > https://bootlin.com <https://bootlin.com> > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#168605): https://lists.openembedded.org/g/openembedded-core/message/168605 Mute This Topic: https://lists.openembedded.org/mt/92635255/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
