On Mon, Aug 8, 2022 at 2:34 PM Alexandre Belloni <[email protected]> wrote: > > Hi, > > On 08/08/2022 08:19:51-0500, Joshua Watt wrote: > > The regex to match github or gitlab was unnecessarily shortened, which > > prevented them from showing up when grepping. > > > > This doesn't apply since we have "classes/sanity: Add comment about > github & gitlab archives" in master. I guess this was one or the other.
Ack, sorry. This was due to feedback on that patch, and I didn't realize it had merged already. Sorry about that. It doesn't really matter to me which one was merged, so dropping this is fine I think I should have done this one as a V2, or at least in-reply-to that one? > > > Signed-off-by: Joshua Watt <[email protected]> > > --- > > meta/classes/insane.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass > > index 37e10ad850..b66926f540 100644 > > --- a/meta/classes/insane.bbclass > > +++ b/meta/classes/insane.bbclass > > @@ -1335,7 +1335,7 @@ def unpack_check_src_uri(pn, d): > > oe.qa.handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % > > pn, d) > > > > for url in d.getVar("SRC_URI").split(): > > - if re.search(r"git(hu|la)b\.com/.+/.+/archive/.+", url): > > + if re.search(r"(github|gitlab)\.com/.+/.+/archive/.+", url): > > oe.qa.handle_error("src-uri-bad", "%s: SRC_URI uses unstable > > GitHub/GitLab archives, convert recipe to use git protocol" % pn, d) > > > > python do_qa_unpack() { > > -- > > 2.33.0 > > > > > > > > > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#169116): https://lists.openembedded.org/g/openembedded-core/message/169116 Mute This Topic: https://lists.openembedded.org/mt/92891575/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
