On Mon, Aug 15, 2022 at 11:30 AM Drew Moseley <[email protected]> wrote:
>
> Hi Khem,
>
> It looks like you recently removed both the dependency on hwrng and
> systemd-udev-settle.  Do you think this change will be useful?

Depending on udev-settle certainly seems an overkill so that should go.
the change you have made will now ensure that this service starts when
dev-hwrng device is created
but loses the order of starting the service. So it may still race with
device creation.

>
> Claudius, any thoughts here?
>
>
> Drew
>
>
>
> On 8/15/22 2:25 PM, [email protected] wrote:
> > From: Drew Moseley <[email protected]>
> >
> > The previous change to remove the dependency on systemd-udev-settle
> > caused boot delays at least on qemu. It seems that change required
> > a hwrng device but that's not necessarily available on all platforms.
> >
> > This changes the "Requires" to a "WantedBy" as modeled after the
> > version of this file on Ubuntu 20.04.
> >
> > Signed-off-by: Drew Moseley <[email protected]>
> > ---
> >   meta/recipes-support/rng-tools/rng-tools/rng-tools.service | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service 
> > b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> > index 0f50890dcb..b013d95932 100644
> > --- a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> > +++ b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> > @@ -3,8 +3,6 @@ Description=Hardware RNG Entropy Gatherer Daemon
> >   DefaultDependencies=no
> >   After=systemd-udev-settle.service
> >   Before=sysinit.target shutdown.target
> > -Requires=dev-hwrng.device
> > -After=dev-hwrng.device
> >   Conflicts=shutdown.target
> >
> >   [Service]
> > @@ -32,3 +30,4 @@ SystemCallFilter=@system-service
> >
> >   [Install]
> >   WantedBy=sysinit.target
> > +WantedBy=dev-hwrng.device
>
> --
> mailto:[email protected]
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#169360): 
https://lists.openembedded.org/g/openembedded-core/message/169360
Mute This Topic: https://lists.openembedded.org/mt/93042904/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to