Hi Otavio, On 2022-08-23 16:03, Otavio Salvador wrote:
Em ter., 23 de ago. de 2022 às 08:02, Peter Bergin <[email protected]> escreveu:Make unique shell variable names for cargo and rust setup scripts. This change will make it easier to append to the scripts in a bbappend file by using the variable for the script. Before this change it was only possible for the last script as they shared the same variable name. Signed-off-by: Peter Bergin <[email protected]> Why do you want to append them?
In my particular case the rust application I'm building against the SDK is using the crate prost-build (https://crates.io/crates/prost-build) that is used to generate code from .proto files. It is using the tool protoc from protobuf and in order to get it working the variable PROTOC needs to be set. Then my solution was to add that variable to environment-setup.d/rust.sh in the SDK as I thought that was an easy solution and rust.sh is in some way connected to the variable setting. Then looking in to do_install of rust-cross-canadian I saw that the variable ENV_SETUP_SH is first used for rust.sh then for cargo.sh so I could not use it to point out rust.sh. Then I had the idea that it would be better to have one variable for rust.sh and one for cargo.sh.
No strong opinion if this is a good solution or not. I can find other solutions of course. If this break things for other people I hope it will not be accepted. Just wanted to share if it can also help others.
Best regards, /Peter
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#169727): https://lists.openembedded.org/g/openembedded-core/message/169727 Mute This Topic: https://lists.openembedded.org/mt/93201518/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
