On Thu, 2022-09-01 at 17:42 -0600, Alejandro Hernandez Samaniego wrote: > There could be IMAGE_CLASSES designed to work on images which arent > necessarily compatible with baremetal-images, one example is the > license_image class which relies on the package managers functionality > during do_rootfs, for baremetal images no rootfs is created hence the > package manager shouldnt be invoked, we need to avoid inheriting such > class to fix this behavior. > > inherit BAREMETAL_IMAGE_CLASSES for baremetal images but set the default > to IMAGE_CLASSES, whilst removing undesired classes in an intermediate > step to avoid incompatibilities. > > Signed-off-by: Alejandro Enedino Hernandez Samaniego <[email protected]> > --- > meta/classes-recipe/baremetal-image.bbclass | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/baremetal-image.bbclass > b/meta/classes-recipe/baremetal-image.bbclass > index d3377a92fa..2f07dec4ac 100644 > --- a/meta/classes-recipe/baremetal-image.bbclass > +++ b/meta/classes-recipe/baremetal-image.bbclass > @@ -18,8 +18,15 @@ > ## Emulate image.bbclass > # Handle inherits of any of the image classes we need > IMAGE_CLASSES ??= "" > -IMGCLASSES = " ${IMAGE_CLASSES}" > +BAREMETAL_IMAGE_CLASSES ?= " ${IMAGE_CLASSES}" > + > +# The license_image class relies on package managers used on do_rootfs > +# these dont exist for baremetal images since no rootfs is created. > +BAREMETAL_IMAGE_CLASSES:remove = "license_image" > + > +IMGCLASSES = " ${BAREMETAL_IMAGE_CLASSES}" > inherit ${IMGCLASSES} > + > # Set defaults to satisfy IMAGE_FEATURES check > IMAGE_FEATURES ?= "" > IMAGE_FEATURES[type] = "list"
This is going to become a usability nightmare. Can we patch license_image to just silently do nothing for baremetal? Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#170250): https://lists.openembedded.org/g/openembedded-core/message/170250 Mute This Topic: https://lists.openembedded.org/mt/93408418/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
