> -----Original Message----- > From: Alexander Kanavin <[email protected]> > Sent: den 16 september 2022 11:57 > To: Peter Kjellerstedt <[email protected]> > Cc: ChenQi <[email protected]>; OE-core <openembedded- > [email protected]>; Alexander Kanavin <[email protected]> > Subject: Re: [OE-core] [PATCH 1/7] scripts/oe-setup-builddir: add a check > that TEMPLATECONF is valid > > On Fri, 16 Sept 2022 at 00:59, Peter Kjellerstedt > <[email protected]> wrote: > > > > Since our code is a wrapper around oe-init-build-env, it would have to do > > the exact same calculations as are done in oe-setup-builddir, and if you > > look at that script, you will see that there are actually quite a lot of > > options to determine the name of the build directory. > > Line numbers as of current master HEAD please. I am looking at the > script right now and I am not seeing any options: it simply takes > $BUILDDIR var passed in from oe-init-build-env. And oe-init-build-env > sets that to either what was given on the command line, or defaults to > 'build'.
Sorry, my fault. I forgot that while the build directory is created in oe-setup-builddir, the path that is used is actually determined in oe-buildenv-internal, line 42-81. And this is the part that I would have to duplicate. Now, I do not need all of it (it can be reduced to 19 lines), but it still means I am duplicating the logic from OE-Core and if that changes, we may or may not notice... That said, unless I can convince you that the right thing to do is to remove templateconf.cfg for all builds if it does not contain a valid path according to the new rules (and not only for OE-Core and Poky), then I still need to duplicate the code to determine the build directory to be able to remove the templateconf.cfg file to avoid having to make all our developers do it manually... > > Again, to the best of my knowledge this will work in the wrapper, and > you need to show otherwise: > > mkdir -p $builddir/conf > write_out $builddir/conf/bblayers.conf > . oe-init-build-env $builddir > > Something still doesn't compute here and we need to get to the bottom > of it. Let's focus on this for now, please. > > Alex //Peter
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#170824): https://lists.openembedded.org/g/openembedded-core/message/170824 Mute This Topic: https://lists.openembedded.org/mt/93368468/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
