Hello Thomas
Thanks for the patch!
On 05.10.22 16:57, Thomas Perrot via lists.openembedded.org wrote:
Otherwise when the installation of recommended packages is prevented
(NO_RECOMMENDATIONS = "1"), then splash screen will not be cast.
Signed-off-by: Thomas Perrot <[email protected]>
There's a problem with the way you send your patches though. I used to
have the same one.
If I apply your patch through "git am", the author of the commit is:
Thomas Perrot via lists.openembedded.org
<[email protected]>
instead of
Thomas Perrot <[email protected]>
Because of this issue, the maintainer has to manually fix this field
when accepting your patch. Worse, if he doesn't catch this, that's
harder to fix afterwards.
You should be able to fix this by running:
git config --global sendemail.from "[email protected]"
At least this worked for me from the same domain ;-) See
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email
Could you try to send an update? You could send it to me again through
private-mail first.
Thanks in advance
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171466):
https://lists.openembedded.org/g/openembedded-core/message/171466
Mute This Topic: https://lists.openembedded.org/mt/94137129/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
