On Tue, 1 Nov 2022 at 09:12, Peter Bergin <[email protected]> wrote: > This opened my eyes for the way systemd recipes are built up in oe-core. > It seems a bit the other way around. systemd.inc contains almost only > version information. systemd_251.4.bb is huge and contains a lot of > thing that I think can be shared among versions. If it had been the > other way around it had been easy to have a systemd_git.bb, including > systemd.inc, in my local layer (or upstream if desired) that build > systemd main branch. What do you think of that? Is is worth working on > such a patch? Or are there reasons for that setup?
I prefer the opposite actually. Where possible, I fold the .inc files into the main recipe because that makes maintenance easier, and if someone needs to change that in non-upstreamable manner, they have to perform a full fork in a private layer. I do not like bits and pieces of code scattered all over the place and gathered together by bitbake, that does not help readability. For systemd, I think the reason for systemd.inc is that something else in the same folder is using it. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#172353): https://lists.openembedded.org/g/openembedded-core/message/172353 Mute This Topic: https://lists.openembedded.org/mt/94696056/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
