Hi Enrico, Enrico Scholz via lists.openembedded.org <enrico.scholz= [email protected]> escreveu no dia quarta, 16/11/2022 à(s) 11:24:
> From: Enrico Scholz <[email protected]> > > Transition to ThreadPoolExecutor (eb6a6820928472ef194b963b606454e731f9486f) > broke the > > | Checking sstate mirror object availability: ... > > progress bar because the removed 'thread_worker' was still referenced > in an asynchronous function. As the result of the future is never > read, the resulting backtrace is silently discarded. > I have tested the patch at the time and the progress bar works as expected, maybe something breaks after that. > > Replace the information given to 'ProcessProgress' by a counter. > > Signed-off-by: Enrico Scholz <[email protected]> > --- > meta/classes-global/sstate.bbclass | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/meta/classes-global/sstate.bbclass > b/meta/classes-global/sstate.bbclass > index 2c8e7b8cc232..3fabca4a3160 100644 > --- a/meta/classes-global/sstate.bbclass > +++ b/meta/classes-global/sstate.bbclass > @@ -925,6 +925,8 @@ sstate_unpack_package () { > BB_HASHCHECK_FUNCTION = "sstate_checkhashes" > > def sstate_checkhashes(sq_data, d, siginfo=False, currentcount=0, > summary=True, **kwargs): > + import itertools > + > found = set() > missed = set() > > @@ -1019,7 +1021,7 @@ def sstate_checkhashes(sq_data, d, siginfo=False, > currentcount=0, summary=True, > connection_cache_pool.put(connection_cache) > > if progress: > - bb.event.fire(bb.event.ProcessProgress(msg, len(tasklist) > - thread_worker.tasks.qsize()), d) > + bb.event.fire(bb.event.ProcessProgress(msg, > next(num_tasks_done) + 1), d) > tasklist = [] > for tid in missed: > @@ -1029,6 +1031,8 @@ def sstate_checkhashes(sq_data, d, siginfo=False, > currentcount=0, summary=True, > if tasklist: > nproc = min(int(d.getVar("BB_NUMBER_THREADS")), len(tasklist)) > > + ## thread-safe counter > + num_tasks_done = itertools.count() > progress = len(tasklist) >= 100 > if progress: > Can the num_tasks_done be moved to there and call the first next(num_tasks_done) so we can remove the +1 on the ProcessProgress Jose > msg = "Checking sstate mirror object availability" > -- > 2.38.1 > > > > > -- Best regards, José Quaresma
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#173388): https://lists.openembedded.org/g/openembedded-core/message/173388 Mute This Topic: https://lists.openembedded.org/mt/95064126/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
