On Fri, 2022-11-18 at 18:08 +0200, Mikko Rapeli wrote: > get_data() uses oeqa test method name and an optional > key to get data from image specific "testimage_data.json" > file located in image deploy directory. Image recipes can > provide custom versions of this file which configures > generic tests for a specific image when testing with > testimage.bbclass > > For example, the parselogs.py runtime test needs image > specific configuration when the image has new errors from > the kernel which acceptable and can be ignored. > > Same machine can be used to generate multiple images with different > runtime behavior so using image as the key and not machine. > > Signed-off-by: Mikko Rapeli <[email protected]> > --- > meta/lib/oeqa/utils/data.py | 41 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 meta/lib/oeqa/utils/data.py > > v2: no changes
I'm afraid I'm really against adding this json approach to adding data and I'm not planning to merge it. I don't like having two different files containing recipe data in different formats and I don't like the datastore not being definitive for a given recipe. I agree we need to be able to extend this data on a per recipe basis but I think we need to do that from the recipes themselves. Just to be clear, even done with json as in this patch, it isn't something which would be an acceptable backport to an LTS. There are two other options. One is to 'abuse' variable flags: OEQA_PARSELOGS_IGNORELIST[qemux86] = "xxx" OEQA_PARSELOGS_IGNORELIST[qemuarm] = "yyy" which I don't like but could likely be made to work today. The other is to introduce some dedicated dict/list like data syntax to support more structured data which I think would be the better solution in the long run but is a bit more work to implement up front. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#173693): https://lists.openembedded.org/g/openembedded-core/message/173693 Mute This Topic: https://lists.openembedded.org/mt/95114899/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
