> -----Original Message-----
> From: [email protected]
> <[email protected]> On Behalf Of leimaohui
> Sent: den 13 december 2022 03:38
> To: [email protected]
> Cc: Lei Maohui <[email protected]>
> Subject: [oe-core][PATCH] libpng: Added "--enable-hardware-optimizations"
> instead of "--enable-arm-neon". Because "--enable-arm-neon" only works for
> armv7, but doesn't work for aarch64. But in fact neon is also enabled for
> aarch64 by default.
The above is a way too long subject. I suggest changing it to:
libpng: Use --enable-hardware-optimizations instead of --enable-arm-neon
And then use the rest of the original subject as the first paragraph
of the commit message:
Because "--enable-arm-neon" only works for armv7, but doesn't work for
aarch64. But in fact neon is also enabled for aarch64 by default.
>
> Reference to libpng-1.6.38/configure,if enable_hardware_optimizations is
> enabled, libpng can judge whether enable enable_arm_neon according
> to $host_cpu.
> ----------------------------------------
> $ cat libpng-1.6.38/configure
> ......
> if test ${enable_hardware_optimizations+y}
> then :
> ......
> # allow enabling hardware optimization on any system:
> case "$host_cpu" in
> arm*|aarch64*)
> enable_arm_neon=yes
>
> printf "%s\n" "#define PNG_ARM_NEON_OPT 2" >>confdefs.h
> ......
> ----------------------------------------
>
> Signed-off-by: Lei Maohui <[email protected]>
> ---
> meta/recipes-multimedia/libpng/libpng_1.6.38.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/libpng/libpng_1.6.38.bb
> b/meta/recipes-multimedia/libpng/libpng_1.6.38.bb
> index dc627203ef..7da71d9d3b 100644
> --- a/meta/recipes-multimedia/libpng/libpng_1.6.38.bb
> +++ b/meta/recipes-multimedia/libpng/libpng_1.6.38.bb
> @@ -22,7 +22,7 @@ BINCONFIG = "${bindir}/libpng-config
> ${bindir}/libpng16-config"
> inherit autotools binconfig-disabled pkgconfig
>
> # Work around missing symbols
> -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES",
> "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}"
> +EXTRA_OECONF:append:class-target = " --enable-hardware-optimizations=on "
Remove the space before the trailing quote.
>
> PACKAGES =+ "${PN}-tools"
>
> --
> 2.25.1
//Peter
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#174510):
https://lists.openembedded.org/g/openembedded-core/message/174510
Mute This Topic: https://lists.openembedded.org/mt/95637494/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
