On Wed, Dec 7, 2022 at 11:11 PM Ola x Nilsson <[email protected]> wrote:
>
> Signed-off-by: Ola x Nilsson <[email protected]>
> ---
> meta/conf/distro/time64.conf | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 meta/conf/distro/time64.conf
>
> diff --git a/meta/conf/distro/time64.conf b/meta/conf/distro/time64.conf
> new file mode 100644
> index 0000000000..99eb06dc0f
> --- /dev/null
> +++ b/meta/conf/distro/time64.conf
I think this file should be called time64.inc to make it similar to
other distro fragments that distros can use.
> @@ -0,0 +1,23 @@
> +GLIBC_64BIT_TIME_FLAGS = "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64"
Also add -D_LARGEFILE_SOURCE here too so we have all dependent changes
in one place
> +
> +# TODO: Only for 32-bit architectures?
> +TARGET_CC_ARCH:append:arm = " ${GLIBC_64BIT_TIME_FLAGS}"
> +TARGET_CC_ARCH:append:armeb = " ${GLIBC_64BIT_TIME_FLAGS}"
> +TARGET_CC_ARCH:append:mips32el = " ${GLIBC_64BIT_TIME_FLAGS}"
I think it should be made generic across all 32bit arches as I
mentioned last time.
> +
> +GLIBC_64BIT_TIME_FLAGS:pn-glibc = ""
> +GLIBC_64BIT_TIME_FLAGS:pn-glibc-tests = ""
> +# pipewire-v4l2 explicitly sets _FILE_OFFSET_BITS=32 to get access to
> +# both 32 and 64 bit file APIs. But it does not handle the time side?
> +# Needs further investigation
> +GLIBC_64BIT_TIME_FLAGS:pn-pipewire = ""
> +GLIBC_64BIT_TIME_FLAGS:pn-gcc-sanitizers = ""
> +
> +INSANE_SKIP:libstd-rs[_usr_lib_rustlib_armv7-poky-linux-gnueabihf_lib_libstd.so]
> = "clock_gettime gettime fcntl fstat64 fstatat64 getsockopt ioctl lstat64
> nanosleep prctl recvmsg sendmsg setsockopt stat64"
> +INSANE_SKIP:librsvg[_usr_bin_rsvg-convert] = "fcntl fstat64 prctl stat64
> clock_gettime"
> +INSANE_SKIP:librsvg[_usr_lib_librsvg-2.so.2.48.0] = "fcntl lstat64
> setsockopt sendmsg fstat64 getsockopt ioctl nanosleep timegm fstatat64 prctl
> mktime gmtime_r recvmsg stat64 clock_gettime localtime_r"
> +
> +# libpulsedsp.so is a preload-library that hooks libc functions
> +INSANE_SKIP:pulseaudio[_usr_lib_pulseaudio_libpulsedsp.so] = "setsockopt
> fcntl"
> +
Earlier I thought we won't need it on musl. Ideally that's true, but
many applications do rely on _FILE_OFFSET_BITS=64 so I think
we will need to include it on musl too even though these defines wont
means much from libc point of view.
> +
> --
> 2.30.2
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#174584):
https://lists.openembedded.org/g/openembedded-core/message/174584
Mute This Topic: https://lists.openembedded.org/mt/95533494/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
