I understand where it comes from, and that's not what I'm trying to express. Why do we need to insert those REQUIRED_DISTRO_FEATURES lines into every recipe that, directly, or indirectly depends on an opengl implementation, even when the component itself uses nothing from the opengl stack?
With gtk4 becoming one of those items, this really does become a maintenance burden. What would happen if we instead drop them all, and keep REQUIRED_DISTRO_FEATURES only in the opengl provider itself, which would be mesa? Alex On Fri, 6 Jan 2023 at 10:11, Yu, Mingli <[email protected]> wrote: > > Hi Alex, > > The gtk4 depends on libepoxy [1] which needs opengl DISTRO_FEATURES and it > makes gtk4 require opengl DISTRO_FEATURES too. And it also introduces the > opengl DISTRO_FEATURES requirements for other recipes which depend on gtk4, > please help to check. > > > [1] > https://git.openembedded.org/openembedded-core/tree/meta/recipes-graphics/libepoxy/libepoxy_1.5.10.bb > > Thanks, > ________________________________ > From: Alexander Kanavin <[email protected]> > Sent: Thursday, January 5, 2023 14:55 > To: Yu, Mingli <[email protected]> > Cc: [email protected] > <[email protected]> > Subject: Re: [OE-core] [PATCH] gcr: add opengl to REQUIRED_DISTRO_FEATURES > > CAUTION: This email comes from a non Wind River email account! > > Do not click links or open attachments unless you recognize the sender and > know the content is safe. > But does this mean we now have to insert required distro features statement > into everything that depends on gtk4? That doesn’t seem useful; it should be > enough to say that only in the recipe where the requirement originates. > > Alex > > On Thu 5. Jan 2023 at 3.10, Yu, Mingli <[email protected]> wrote: > > Hi Alex, > > Yes, The setting REQUIRED_DISTRO_FEATURES = "opengl" is in gtk4 recipe. > Apart from that, gtk4 depends on libepoxy which also needs opengl distro. > > Thanks, > ________________________________ > From: Alexander Kanavin <[email protected]> > Sent: Friday, December 23, 2022 17:43 > To: Yu, Mingli <[email protected]> > Cc: [email protected] > <[email protected]> > Subject: Re: [OE-core] [PATCH] gcr: add opengl to REQUIRED_DISTRO_FEATURES > > CAUTION: This email comes from a non Wind River email account! > > Do not click links or open attachments unless you recognize the sender and > know the content is safe. > Is OpenGL really mandatory for gtk4? > > Alex > > On Fri 23. Dec 2022 at 10.32, Yu, Mingli <[email protected]> wrote: > > From: Mingli Yu <[email protected]> > > Fixes: > $ bitbake gcr > ERROR: Nothing PROVIDES 'gtk4' (but > /build/layers/oe-core/meta/recipes-gnome/gcr/gcr_4.0.0.bb DEPENDS on or > otherwise requires it) > gtk4 was skipped: missing required distro feature 'opengl' (not in > DISTRO_FEATURES) > ERROR: Required build target 'gcr' has no buildable providers. > Missing or unbuildable dependency chain was: ['gcr', 'gtk4'] > > Signed-off-by: Mingli Yu <[email protected]> > --- > meta/recipes-gnome/gcr/gcr_4.0.0.bb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/recipes-gnome/gcr/gcr_4.0.0.bb > b/meta/recipes-gnome/gcr/gcr_4.0.0.bb > index 264069ffd1..22edd386fc 100644 > --- a/meta/recipes-gnome/gcr/gcr_4.0.0.bb > +++ b/meta/recipes-gnome/gcr/gcr_4.0.0.bb > @@ -20,6 +20,8 @@ GTKDOC_MESON_OPTION = "gtk_doc" > inherit gnomebase gtk-icon-cache gi-docgen features_check > upstream-version-is-even vala gobject-introspection gettext mime mime-xdg > UPSTREAM_CHECK_REGEX = "gcr-(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)\.tar.xz" > > +REQUIRED_DISTRO_FEATURES = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', > 'opengl', '', d)}" > + > SRC_URI += > "file://0001-meson.build-correctly-handle-disabled-ssh_agent-opti.patch" > SRC_URI[archive.sha256sum] = > "c45855924f0ee7bab43e2dd38bfafd2ac815c6e9864341c0161e171173dcec7c" > > -- > 2.25.1 > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#175567): https://lists.openembedded.org/g/openembedded-core/message/175567 Mute This Topic: https://lists.openembedded.org/mt/95842308/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
