1. inherit fs-uuid in some-recipe
2. set ROOTFS to some-existing-rootfs
3. make call to get_rootfs_uuid somewhere in that recipe ie.
"${@get_rootfs_uuid(d)}"
3. bitbake some-recipePawel On Fri, 6 Jan 2023 at 12:43, Alexander Kanavin <[email protected]> wrote: > > Can you please describe steps to reproduce? > > Alex > > On Fri 6. Jan 2023 at 13.40, Pawel Zalewski <[email protected]> > wrote: >> >> It is not actually being used by default in Yocto ? >> This was found in kirkstone. >> But regardless, it is wrong and will drop an error. >> >> Kind regards, >> Pawel >> >> On Fri, 6 Jan 2023 at 12:06, Richard Purdie >> <[email protected]> wrote: >> > >> > On Thu, 2022-12-22 at 10:38 +0000, Pawel Zalewski wrote: >> > > The default return value from subprocess.check_output is an encoded byte. >> > > The applied fix will decode the value to a string. >> > > >> > > Signed-off-by: Pawel Zalewski <[email protected]> >> > > --- >> > > meta/classes/fs-uuid.bbclass | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/meta/classes/fs-uuid.bbclass b/meta/classes/fs-uuid.bbclass >> > > index 9b53dfba7a..731ea575bd 100644 >> > > --- a/meta/classes/fs-uuid.bbclass >> > > +++ b/meta/classes/fs-uuid.bbclass >> > > @@ -4,7 +4,7 @@ >> > > def get_rootfs_uuid(d): >> > > import subprocess >> > > rootfs = d.getVar('ROOTFS') >> > > - output = subprocess.check_output(['tune2fs', '-l', rootfs]) >> > > + output = subprocess.check_output(['tune2fs', '-l', rootfs], >> > > text=True) >> > > for line in output.split('\n'): >> > > if line.startswith('Filesystem UUID:'): >> > > uuid = line.split()[-1] >> > >> > >> > That looks reasonable, I just wonder how this has worked until now? Why >> > aren't we seeing errors due to this? >> > >> > Does it mean we don't have some test coverage? or was there silent >> > breakage of some kind this fixes? >> > >> > Cheers, >> > >> > Richard >> >> >>
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#175587): https://lists.openembedded.org/g/openembedded-core/message/175587 Mute This Topic: https://lists.openembedded.org/mt/95823853/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
