Hi, Richard
> I'm a bit worried that we don't want this option floating. How about something
> like:
>
> ARMNEON = "${@bb.utils.contains("TUNE_FEATURES", "neon",
> "--enable-arm-neon=on", "--enable-arm-neon=off", d)}"
> ARMNEON:aarch64 = "--enable-hardware-optimizations=on"
> EXTRA_OECONF += "${ARMNEON}"
Thanks, it does work and I will send V2 patch.
Best regards
Lei
> -----Original Message-----
> From: [email protected]
> <[email protected]> On Behalf Of Richard Purdie
> Sent: Monday, January 9, 2023 6:44 PM
> To: Lei, Maohui <[email protected]>;
> [email protected]
> Subject: Re: [OE-core] [PATCH] libpng: Enable NEON for aarch64 to enensure
> consistency with arm32.
>
> On Fri, 2023-01-06 at 09:49 +0800, leimaohui wrote:
> > - When NEON is not enabled for arm32, it shouldn't be disable
> > enable-arm-neon
> for other arches.
> > - NEON is enabled for aarch64 by default, so, to ensure consistency with
> > arm32,
> reference to libpng-1.6.38/configure, added enable_hardware_optimizations
> option for aarch64.
> >
> > Signed-off-by: Lei Maohui <[email protected]>
> > ---
> > meta/recipes-multimedia/libpng/libpng_1.6.39.bb | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-multimedia/libpng/libpng_1.6.39.bb
> > b/meta/recipes-multimedia/libpng/libpng_1.6.39.bb
> > index d9dcf37..b17261a 100644
> > --- a/meta/recipes-multimedia/libpng/libpng_1.6.39.bb
> > +++ b/meta/recipes-multimedia/libpng/libpng_1.6.39.bb
> > @@ -22,7 +22,8 @@ BINCONFIG = "${bindir}/libpng-config
> ${bindir}/libpng16-config"
> > inherit autotools binconfig-disabled pkgconfig
> >
> > # Work around missing symbols
> > -EXTRA_OECONF:append:class-target = "
> ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on",
> "--enable-arm-neon=off", d)}"
> > +EXTRA_OECONF:append:class-target = "
> ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", " ",
> d)}"
> > +EXTRA_OECONF:append:aarch64 = " --enable-hardware-optimizations=on "
> >
> > PACKAGES =+ "${PN}-tools"
>
> I'm a bit worried that we don't want this option floating. How about something
> like:
>
> ARMNEON = "${@bb.utils.contains("TUNE_FEATURES", "neon",
> "--enable-arm-neon=on", "--enable-arm-neon=off", d)}"
> ARMNEON:aarch64 = "--enable-hardware-optimizations=on"
> EXTRA_OECONF += "${ARMNEON}"
>
> ?
>
> Cheers,
>
> Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#175703):
https://lists.openembedded.org/g/openembedded-core/message/175703
Mute This Topic: https://lists.openembedded.org/mt/96086131/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
