I sent oe-core patches upstream that aren't mine all the time. Sometimes I as well don't even understand them fully, and then I have upstream explain to me what's wrong with it or why is it not appropriate or poorly written. Or they rework it themselves. The primary goal is to engage the upstream and make them aware, and no one expects you to produce a perfect patch and complete understanding of the issue in your head up-front.
My request is simply to go through the not-too-hard technicality of sending the patch via opening a merge request, so that there is an link for it that can be followed up later by you, or by someone else. Later can be measured in weeks or months, and often is. Alex On Thu, 19 Jan 2023 at 18:22, Markus Volk <[email protected]> wrote: > > I don't want to push this work to you. Just wanted to give a reason, why I'd > rather dont like to do myself, at least for the next days. Have still plenty > of work lying here and in fact I do this only for fun and thats what it still > needs to be to give me reason. I'm not related to technical things for a > living. It's just, that I had an issue with gnome-disks and as a side effect > I realized that sgdisk has an issue as well and found a fix for it. > But if thats not appropriate like this, just drop that commit for now. Will > send a v2 when I've been digging into it enough, to have the feeling that I > am halfway knowing what I talk about, if sending a merge request for a patch > I didn't create. > > > Am Do, 19. Jan 2023 um 18:10:05 +0100 schrieb Alexander Kanavin > <[email protected]>: > > On Thu, 19 Jan 2023 at 16:27, Markus Volk <[email protected]> wrote: > > But its neither my patch nor am I familiar with sourceforge or the actual > issue with popt ... and I'm not keen on changing that. I think if the > gptfdisk maintainer wants to release a new version, he will be able to find > the patch on the net like I was. And if he wants to get more help from the > community it would be a good idea to have a git repo available somewhere. Or > am I missing something and just wasn't able to find it? > > The git repo is in fact on sourceforge: > https://sourceforge.net/p/gptfdisk/code/ci/master/tree/ and you can open a > merge request there. There's one from Khem for example. Please do not come up > with reasons to push this work (submitting patches upstream) on me; I do not > appreciate that. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#176156): https://lists.openembedded.org/g/openembedded-core/message/176156 Mute This Topic: https://lists.openembedded.org/mt/96376633/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
