On Wed, 2023-01-25 at 09:31 +0100, Louis Rannou wrote:
> From: Louis Rannou <[email protected]>
>
> [YOCTO #9070]
>
> Add a new selftest to validate the locales generation. This selftest builds a
> complete target with GLIBC_GENERATE_LOCALES, IMAGE_LINGUAS,
> ENABLE_BINARY_LOCALE_GENERATION set. The locales are tested through a ssh
> connection in three manners: checks if the locales exist in the
> locale-archive,
> if it does exist for the glibc and if it can be generated.
>
> Signed-off-by: Louis Rannou <[email protected]>
> ---
> meta/lib/oeqa/selftest/cases/locales.py | 54 +++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
> create mode 100644 meta/lib/oeqa/selftest/cases/locales.py
>
> diff --git a/meta/lib/oeqa/selftest/cases/locales.py
> b/meta/lib/oeqa/selftest/cases/locales.py
> new file mode 100644
> index 0000000000..089ca594a1
> --- /dev/null
> +++ b/meta/lib/oeqa/selftest/cases/locales.py
> @@ -0,0 +1,54 @@
> +#
> +# SPDX-License-Identifier: MIT
> +#
> +
> +from oeqa.selftest.case import OESelftestTestCase
> +from oeqa.core.decorator import OETestTag
> +from oeqa.utils.commands import bitbake, runqemu
> +from oeqa.utils.sshcontrol import SSHControl
> +
> +class LocalesTest(OESelftestTestCase):
> +
> + @OETestTag("runqemu")
> + def test_locales(self):
> + """
> + Summary: Test the locales through a ssh connection
> + Expected: 1. Check the locale exist in the locale-archive
> + 2. Check it the locale exist for the glibc
> + 3. Check the locale can be generated
> + Product: oe-core
> + Author: Louis Rannou <[email protected]>
> + AutomatedBy: Louis Rannou <[email protected]>
> + """
> +
> + features = []
> + features.append('EXTRA_IMAGE_FEATURES = "ssh-server-openssh
> empty-root-password allow-empty-password allow-root-login"')
> + features.append('IMAGE_INSTALL:append = " glibc-utils localedef"')
> + features.append('GLIBC_GENERATE_LOCALES = "en_US.UTF-8 fr_FR.UTF-8"')
> + features.append('IMAGE_LINGUAS:append = " en-us fr-fr"')
> + features.append('ENABLE_BINARY_LOCALE_GENERATION = "1"')
> + self.write_config("\n".join(features))
> +
> + # Build a core-image-minimal
> + bitbake('core-image-minimal')
> +
> + with runqemu("core-image-minimal") as qemu:
> + # Attempt to ssh with each user into qemu with empty password
> + ssh = SSHControl(ip=qemu.ip, logfile=qemu.sshlog, user='root')
Thanks for this, in general this looks good and it would be great to
get a test for this enabled so I'm very happy to see the patch.
I did have one question about the above line. I think you can just use
qemu.run() to run commands over ssh and I suspect the above might
create a second ssh connection which might then have lifecycle issues.
Did you try qemu.run() and have issues? I noticed a lot of our tests
use run_serial() which I hadn't realised until I looked!
Cheers,
Richard
> + cmd = "locale -a"
> + status, output = ssh.run(cmd)
> + # output must includes fr_FR or fr_FR.UTF-8
> + self.assertEqual(status, 0, msg='locale -a test failed: %s' %
> output)
> + self.assertIn("fr_FR", output, msg='Incorrect output: %s' %
> output)
> +
> + cmd = "localedef --list-archive -v | grep fr_FR.utf8"
> + status, output = ssh.run(cmd)
> + # output must includes fr_FR.utf8
> + self.assertEqual(status, 0, msg='localedef test failed: %s' %
> output)
> +
> + cmd = "LANG=fr_FR.UTF-8 locale"
> + status, output = ssh.run(cmd)
> + # output must includes fr_FR.UTF-8
> + self.assertEqual(status, 0, msg='locale test failed: %s' %
> output)
> + self.assertIn("LANG=fr_FR.UTF-8", output,
> + msg='Incorrect output: %s' % output)
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176388):
https://lists.openembedded.org/g/openembedded-core/message/176388
Mute This Topic: https://lists.openembedded.org/mt/96517246/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
