On Mon, Feb 6, 2023 at 1:36 PM Tom Hochstein <tom.hochst...@nxp.com> wrote:
>
> Oops, I don’t often send for non OE-Core and I forgot there was a separate
> mailing list for that. I usually just cut and paste from here:
>
>
>
> http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_patches
>
>
>
> Which makes it easy to overlook the mailing list requirement.
>
>
>
> There are several examples in the repo that use this same pattern. Here’s one:
>
>
>
> https://github.com/openembedded/meta-openembedded/commit/7163946b56539725d5a5868a9318e56e713a4a95
>
>
>
> It has the advantage of not installing the header in the image. Should the
> -dev solution be preferred?
if these are development headers and libs then yes its better since it
goes with the general philosophy of putting these files in -dev pkgs.
>
>
>
> Tom
>
>
>
> From: Martin Jansa <martin.ja...@gmail.com>
> Sent: Monday, February 6, 2023 3:13 PM
> To: Tom Hochstein <tom.hochst...@nxp.com>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [meta-oe][PATCH] nlohmann-json: Allow empty main
> package for SDK
>
>
>
> Wrong ML and why do you want to install empty package? Add nlohmann-json-dev
> to imx-gpu-sdk recipe instead.
>
>
>
> On Mon, Feb 6, 2023 at 10:09 PM Tom Hochstein <tom.hochst...@nxp.com> wrote:
>
> The header-only package cannot be included in the SDK without marking
> the main package with ALLOW_EMPTY.
>
> Fixes rootfs problem:
> ```
> The following packages have unmet dependencies:
> imx-gpu-sdk : Depends: nlohmann-json but it is not installable
> E: Unable to correct problems, you have held broken packages.
> ```
>
> Signed-off-by: Tom Hochstein <tom.hochst...@nxp.com>
> ---
> meta-oe/recipes-devtools/nlohmann-json/nlohmann-json_3.11.2.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-devtools/nlohmann-json/nlohmann-json_3.11.2.bb
> b/meta-oe/recipes-devtools/nlohmann-json/nlohmann-json_3.11.2.bb
> index 502262820..6cf27755e 100644
> --- a/meta-oe/recipes-devtools/nlohmann-json/nlohmann-json_3.11.2.bb
> +++ b/meta-oe/recipes-devtools/nlohmann-json/nlohmann-json_3.11.2.bb
> @@ -18,7 +18,7 @@ inherit cmake
> EXTRA_OECMAKE += "-DJSON_BuildTests=OFF"
>
> # nlohmann-json is a header only C++ library, so the main package will be
> empty.
> -
> +ALLOW_EMPTY:${PN} = "1"
> RDEPENDS:${PN}-dev = ""
>
> BBCLASSEXTEND = "native nativesdk"
> --
> 2.25.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176800):
https://lists.openembedded.org/g/openembedded-core/message/176800
Mute This Topic: https://lists.openembedded.org/mt/96793459/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
