On 13/02/2023 13:04, Markus Volk wrote: > Not all arm platforms support neon and runtime detection for this feature is > currently not reliable. Add a PACKAGECONFIG that disables neon support for arm > but can be manually enabled. > > Enable neon for aarch64 by default > > Signed-off-by: Markus Volk <[email protected]> > --- > meta/recipes-graphics/graphene/graphene_1.10.8.bb | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-graphics/graphene/graphene_1.10.8.bb > b/meta/recipes-graphics/graphene/graphene_1.10.8.bb > index 813ff74adf..199c460feb 100644 > --- a/meta/recipes-graphics/graphene/graphene_1.10.8.bb > +++ b/meta/recipes-graphics/graphene/graphene_1.10.8.bb > @@ -10,8 +10,10 @@ inherit gnomebase gobject-introspection gtk-doc > SRC_URI[archive.sha256sum] = > "a37bb0e78a419dcbeaa9c7027bcff52f5ec2367c25ec859da31dfde2928f279a" > > # gtk4 & mutter 41.0 requires graphene build with introspection > -PACKAGECONFIG ?= "introspection" > +PACKAGECONFIG ?= "introspection ${@bb.utils.contains('TUNE_FEATURES', > 'aarch64', 'neon', '', d)}" > + > PACKAGECONFIG[introspection] = > "-Dintrospection=enabled,-Dintrospection=disabled," > +PACKAGECONFIG[neon] = "-Darm_neon=true,-Darm_neon=false," > > GTKDOC_MESON_OPTION = "gtk_doc" > > >
Can you please add a comment in the .bb file with a note saying that Neon support gets disabled by default on ARM-32 platforms because of the following upstream bug: https://github.com/ebassi/graphene/issues/215 ? That way anyone can known in the future why that was disabled for ARM-32 and check if the upstream issue got fixed in order to enable it back by default. There is a related discussion at: https://github.com/Igalia/meta-webkit/pull/448
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#177103): https://lists.openembedded.org/g/openembedded-core/message/177103 Mute This Topic: https://lists.openembedded.org/mt/96933955/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
