Thank you for the additional tips. This morning I was trying to close out the asks from yesterday. I was about to submit yet again and then I saw your message :D. I will need to try to get to the additional asks this evening instead given the workday is about to begin full on.
On 2/20/23 08:09, Richard Purdie wrote: > Hi Richard, > > Thanks for the patch! > > There are a few things that need tweaking. Firstly, the shortlog and > commit log aren't quite right. The shortlog needs to be along the lines > of: > > <area/recipename>: <short summary of the change> > > so something like: > > docbook-xml: Switch from debian packages to upstream docbook sources > > This means someone glancing at the shortlogs can know which area it > applies to and what it was about (in summary). > > After this you'd have a more verbose log message and I usually put the > [YOCTO #13270] at the end on a line of it's own. > > I've commented a little more below inline. > > I think 4.0 support was removed, if so, that should be mentioned in the > commit message log. I then noticed the note about that is in the other > commit, it should be in this one! > > On Sun, 2023-02-19 at 21:38 +0000, Richard Elberger wrote: >> --- >> .../docbook-xml/docbook-xml-dtd4_4.5.bb | 74 ++++++++++++------- >> 1 file changed, 49 insertions(+), 25 deletions(-) >> >> diff --git a/meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb >> b/meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb >> index 2bec1442af..71aa8c14ec 100644 >> --- a/meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb >> +++ b/meta/recipes-devtools/docbook-xml/docbook-xml-dtd4_4.5.bb >> @@ -1,30 +1,54 @@ >> SUMMARY = "Document type definitions for verification of XML data files" >> DESCRIPTION = "Document type definitions for verification of XML data \ >> -files against the DocBook rule set, it ships with the latest DocBook 4.5 \ >> -XML DTD, as well as a selected set of legacy DTDs for use with older \ >> -documents, including 4.0, 4.1.2, 4.2, 4.3 and 4.4" >> -HOMEPAGE = "http://www.docbook.org/xml/"; >> +files against the DocBook rule set." >> +HOMEPAGE = "https://docbook.org"; >> >> -LICENSE = "OASIS" >> -LIC_FILES_CHKSUM = >> "file://${WORKDIR}/LICENSE-OASIS;md5=c608985dd5f7f215e669e7639a0b1d2e" >> +inherit allarch >> +BBCLASSEXTEND = "native" > BBCLASSEXTEND by concention is at the end of the recipe. I see it moves > in the second patch and it wasn't clear what the two different purposes > of the patch were. Style fixes are ok as patch but if the first patch > is introducing them, we may as well squash things? >> -# Note: the upstream sources are not distributed with a license file. >> -# LICENSE-OASIS is included as a "patch" to workaround this. When >> -# upgrading this recipe, please verify whether this is still needed. >> -SRC_URI = >> "http://snapshot.debian.org/archive/debian/20160728T043443Z/pool/main/d/docbook-xml/docbook-xml_${PV}.orig.tar.gz >> \ >> - file://LICENSE-OASIS \ >> - file://docbook-xml-update-catalog.xml.patch \ >> -" >> +# To support apps with xml schema backward compatibility, we must >> +# install a set of schemas. Install the latest based on PV and then >> +# name any specific versions as required. TODO: Figure out a mechanism >> +# to filter exactly which versions are necessary, if that's even >> +# possible. >> +# >> +# DocBook.org lists available packages at https://docbook.org/xml/ >> +# >> +# These packages are available as source but it requires the ability >> +# to use the Gradle build system to do so. It might be safer to use >> +# the source tree which would also enable proper SBOM generation >> +# through the bitbake build system. https://github.com/docbook/docbook > "packages" is an overloaded term. Do you mean packages here? Components > maybe? > >> +# >> >> -SRC_URI[md5sum] = "487b4d44e15cffb1f4048af23f98208e" >> -SRC_URI[sha256sum] = >> "b0f8edcf697f5318e63dd98c9a931f3fee167af0805ba441db372e0f17b2a44f" >> +S = "${WORKDIR}" >> >> -UPSTREAM_CHECK_URI = "${DEBIAN_MIRROR}/main/d/docbook-xml/" >> +SRC_URI += >> "https://docbook.org/xml/4.1.2/docbkx412.zip;name=payload412;subdir=docbook-xml-4.1.2"; >> +SRC_URI[payload412.md5sum] = "900d7609fb7e6d78901b357e4acfbc17" > We've effectively dropped md5sums so there is no need to add new ones. > > Cheers, > > Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#177402): https://lists.openembedded.org/g/openembedded-core/message/177402 Mute This Topic: https://lists.openembedded.org/mt/97074292/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
