I agree. The problem I have with these variable names is that it's ambiguous
whether the features will be included or excluded from the backfill. All you
can tell from the names is that the values were 'considered'. What does that
mean? You have to go to the manual to find the full meaning.
What's important about the variables is that they will be 'excluded' from the
backfill, so this does look much clearer to me:
DISTRO_FEATURES_BACKFILL_EXCLUDED += "some-feature"
Is there a good reason why we have this separate variable and can't just do
this?
DISTRO_FEATURES_BACKFILL:remove = "some-feature"
Tom
-----Original Message-----
From: [email protected]
<[email protected]> On Behalf Of Michael Opdenacker via
lists.openembedded.org
Sent: Thursday, February 23, 2023 11:00 AM
To: OE-core <[email protected]>
Cc: YP docs mailing list <[email protected]>
Subject: [OE-core] [DISTRO|MACHINE]_FEATURES_BACKFILL_CONSIDERED: confusing
variable names?
Greetings
Anybody else finding the DISTRO_FEATURES_BACKFILL_CONSIDERED and
MACHINE_FEATURES_BACKFILL_CONSIDERED variable names confusing?
According to the documentation about "feature backfilling"
(https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.yoctoproject.org%2Fref-manual%2Ffeatures.html%23ref-features-backfill&data=05%7C01%7Ctom.hochstein%40nxp.com%7Cf4e5b1f4523a469612dc08db15bf5d8e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638127683879148065%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4i2IX0GpQlQXAh8Jausfvb2o1oF6MBZaU144KHKjcKg%3D&reserved=0),
these variables allow to exclude some features from being backfilled.
I'm not a native English speaker, but for me, "considered" carries the
intention to include a feature, not to exclude one.
Shouldn't we call these variables DISTRO_FEATURES_BACKFILL_EXCLUDED and
MACHINE_FEATURES_BACKFILL_EXCLUDED instead ?
Thanks in advance
Cheers
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Ctom.hochstein%40nxp.com%7Cf4e5b1f4523a469612dc08db15bf5d8e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638127683879148065%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=S4rZtW35Uxk1ww8OkrPlCJdlI2FWgIpxHcq7PDq2M1o%3D&reserved=0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177638):
https://lists.openembedded.org/g/openembedded-core/message/177638
Mute This Topic: https://lists.openembedded.org/mt/97187180/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
