Hi, On 3/1/23 09:52, Alexandre Belloni wrote: > On 01/03/2023 01:03:04+0100, Yoann Congal wrote: >> From: Pavel Modilaynen <[email protected]> >> >> Use close-on-exec (O_CLOEXEC) flag when open log file to >> make sure its file descriptor is not leaked to parent >> process on fork/exec. >> >> Fixes [YOCTO #13311] >> > > This is missing the author's SoB
That is right. But, as you would have noticed by now, his mail address is not valid anymore... What is the proper way to handle this? * Should I track him to ask him a proper "Signed-off" patch ? (He seems to have changed company) * Should I change the author of the patch? (I do not like this but on the other hand, the change is quite trivial) * Something I have not thought of? > >> Signed-off-by: Mingli Yu <[email protected]> >> Signed-off-by: Yoann Congal <[email protected]> >> --- >> pseudo_util.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/pseudo_util.c b/pseudo_util.c >> index 64636b7..b58036f 100644 >> --- a/pseudo_util.c >> +++ b/pseudo_util.c >> @@ -1611,7 +1611,7 @@ pseudo_logfile(char *filename, char *defname, int >> prefer_fd) { >> } >> free(filename); >> } >> - fd = open(pseudo_path, O_WRONLY | O_APPEND | O_CREAT, 0644); >> + fd = open(pseudo_path, O_WRONLY | O_APPEND | O_CREAT | O_CLOEXEC, 0644); >> if (fd == -1) { >> pseudo_diag("help: can't open log file %s: %s\n", pseudo_path, >> strerror(errno)); >> } else { >> -- >> 2.30.2 >> > >> >> >> > > -- Yoann Congal Smile ECS - Tech Expert
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#177877): https://lists.openembedded.org/g/openembedded-core/message/177877 Mute This Topic: https://lists.openembedded.org/mt/97303652/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
