On Fri 17. Mar 2023 at 12.01, Mikko Rapeli <[email protected]> wrote:
> Hi, > > On Fri, Mar 17, 2023 at 11:39:23AM +0100, Alexander Kanavin wrote: > > This doesn’t seem right. We should not give special privileges to tooling > > from any particular host distro. If you need to manipulate images, build > > e2fsprogs-native and run that. > > This is about ext4 images breaking compatibility with older versions of > tooling used manipulate the images. For Debian the upstream maintainers > and Debian package maintainers agreed to keep the backwards > compatibility for longer time. I think that makes sense for yocto too. > > While I agree that using e2fsprogs-native is a solution too, I also > agree that a lot of users are using non-yocto e2fsprogs when e.g. > flashing images to target HW. Breaking compatibility can quite simply be > avoided and upstream will maintain this branch. Win win from my point of > view. But then we should put e2fsprogs into buildtools-tarball(-extended). It’s not any different to providing compatible gcc, when one from the host distro is too old. Taking a custom branch creates a maintenance problem. What if it stops being maintained? Will it follow proper upstream closely? Can we ever drop this backwards compatibility? It creates a long term headache that I do not want. Alex > > Cheers, > > -Mikko > > > Alex > > > > On Fri 17. Mar 2023 at 10.09, Mikko Rapeli <[email protected]> > wrote: > > > > > From: Jerome Forissier <[email protected]> > > > > > > When trying to use e2fsck <= 1.47.0 on the root filesystem (for > example, > > > to resize a partition after copying the image to a USB stick on a > > > computer running current Ubuntu [22.04] or Debian), an error is > > > reported: > > > > > > e2fsck 1.46.5 (30-Dec-2021) > > > /dev/sdb2 has unsupported feature(s): FEATURE_C12 > > > e2fsck: Get a newer version of e2fsck! > > > > > > This has been discussed in [2] and a fix was made for use by > > > Debian-based distros in [3]. Let's pick that version. > > > > > > Link: [1] > https://gitlab.com/Linaro/trusted-reference-stack/trs/-/issues/1 > > > Link: [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031622 > > > Link: [3] > > > > https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/commit/?h=debian/master&id=1181f164c48574a4813bfa203dbd7b4123154021 > > > > > > Binary compatibility of generated ext4 file system images is important > > > so it's better to use the "debian/master" branch. > > > > > > Signed-off-by: Jerome Forissier <[email protected]> > > > Signed-off-by: Mikko Rapeli <[email protected]> > > > --- > > > meta/recipes-devtools/e2fsprogs/e2fsprogs.inc | 2 +- > > > .../e2fsprogs/{e2fsprogs_1.47.0.bb => e2fsprogs_1.47.0-2.bb} | 2 > +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > rename meta/recipes-devtools/e2fsprogs/{e2fsprogs_1.47.0.bb => > > > e2fsprogs_1.47.0-2.bb} (99%) > > > > > > diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs.inc > > > b/meta/recipes-devtools/e2fsprogs/e2fsprogs.inc > > > index f41a5d0b4e..2f54896e8c 100644 > > > --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs.inc > > > +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs.inc > > > @@ -19,7 +19,7 @@ LIC_FILES_CHKSUM = > > > "file://NOTICE;md5=d50be0580c0b0a7fbc7a4830bbe6c12b \ > > > SECTION = "base" > > > DEPENDS = "util-linux attr autoconf-archive" > > > > > > -SRC_URI = "git:// > > > git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git;branch=master" > > > +SRC_URI = "git:// > > > git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git;branch=debian/master" > > > S = "${WORKDIR}/git" > > > > > > inherit autotools gettext texinfo pkgconfig multilib_header > > > update-alternatives ptest > > > diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb > > > b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0-2.bb > > > similarity index 99% > > > rename from meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb > > > rename to meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0-2.bb > > > index 2620610903..9bf89ba0c4 100644 > > > --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb > > > +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0-2.bb > > > @@ -10,7 +10,7 @@ SRC_URI:append:class-native = " \ > > > file://quiet-debugfs.patch \ > > > " > > > > > > -SRCREV = "f4c9cc4bedacde8408edda3520a32d3842290112" > > > +SRCREV = "1181f164c48574a4813bfa203dbd7b4123154021" > > > UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+\.\d+(\.\d+)*)$" > > > > > > EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} \ > > > -- > > > 2.34.1 > > > > > > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#178756): https://lists.openembedded.org/g/openembedded-core/message/178756 Mute This Topic: https://lists.openembedded.org/mt/97669707/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
