On Wed, 2023-04-05 at 16:20 -0400, Bruce Ashfield wrote: > On Wed, Apr 5, 2023 at 3:24 PM Bartosz Golaszewski <[email protected]> wrote: > > > > From: Bartosz Golaszewski <[email protected]> > > > > Some PACKAGECONFIG switches enable building of additional artifacts that > > end up in sub-packages for a recipe. For example in foo.bb we have: > > > > PACKAGES =+ "foo-bar" > > PACKAGECONFIG[bar] = "--enable-bar,--disable-bar,libdep" > > FILES:foo-bar = "${bindir}/bar" > > > > Where ${bindir}/bar is only installed if PACKAGECONFIG contains "bar". > > > > In order to add foo-bar to the image we need to do: > > > > IMAGE_INSTALL:append = " foo-bar" > > PACKAGECONFIG:append:pn-foo = " bar" > > > > This is redundant so with this change we need to add: > > > > PACKAGECONFIGEXTENDS:foo-bar = "bar" > > FWIW, I prefer the explicit IMAGE_INSTALL and PACKAGECONFIG, as it > keeps the manipulations visible. > > The level of coordination that this is doing is more like a distro > feature, or somewhere around an image feature .. and image features > are manipulated in image recipes, as the contents aren't global. > > So regardless of whether or not the behind the scenes work is desired, > from what I'm seeing, this breaks the namespace and separation between > a recipe variable and an image recipe variable. Depending on what the > target of a build is (the recipe versus an image) both won't even be > valid in a given run, so the variable tweaks won't work or will create > races/other issues.
I'd agree with Bruce. PACKAGECONFIG is controlling which packages get built and is a recipe or distro configuration change. Images are a separate thing which may or may not include a given package. You may build multiple images in a single build which may or may not include a given package. Mixing up these two concepts is asking for trouble and will just end up causing confusion. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#179752): https://lists.openembedded.org/g/openembedded-core/message/179752 Mute This Topic: https://lists.openembedded.org/mt/98090033/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
