On Wed, 2023-04-05 at 07:07 -0500, Patrick Williams wrote:
> On Wed, Apr 05, 2023 at 09:24:24AM +0100, Richard Purdie wrote:
> > On Tue, 2023-04-04 at 19:38 -0500, Patrick Williams wrote:
> > >
> > > -PERLVERSION := "${@get_perl_version(d)}"
> > > +PERLVERSION = "${@get_perl_version(d)}"
> > > PERLVERSION[vardepvalue] = ""
> > >
> > >
> > > @@ -49,7 +49,7 @@ def get_perl_arch(d):
> > > return m.group(1)
> > > return None
> > >
> > > -PERLARCH := "${@get_perl_arch(d)}"
> > > +PERLARCH = "${@get_perl_arch(d)}"
> > > PERLARCH[vardepvalue] = ""
> > >
> >
> > Most code seems to use ${@get_perl_version(d)} and ${@get_perl_arch(d)}
> > directly so perhaps we should just remove the above instead and use
> > these in meta-security too?
>
> I submitted the change to meta-security[1] and changed the one in
> openbmc/meta-phosphor[2] as well.
>
> Do you want me to go ahead and delete these variables? Is there any
> documentation / change-log that I should update as well?
>
> 1.
> https://lore.kernel.org/yocto/[email protected]/T/#u
> 2. https://gerrit.openbmc.org/c/openbmc/openbmc/+/62164
Since nothing key seems to be using them any more we should just be
able to remove them.
We should probably make a note in the migration guide for the next
release and check the variables aren't mentioned in the manuals but at
a quick look I don't think they are. The migration guide is still being
worked on for the current release so queuing the change might confuse
things more than it helps right now :/.
Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#179753):
https://lists.openembedded.org/g/openembedded-core/message/179753
Mute This Topic: https://lists.openembedded.org/mt/98073811/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
