Hi,
I stumbled on some code in update-alternatives.bbclass that I suspect is
missed when we changed to new override syntax but I'm a bit unsure and
would like some more eyes and comments on this. Doing debugging with
logging I see that the class is fetching variables like
'ALTERNATIVE_${PN}' in the code at:
https://git.yoctoproject.org/poky/tree/meta/classes-recipe/update-alternatives.bbclass#n89
I think a patch to correct things could be:
diff --git a/meta/classes-recipe/update-alternatives.bbclass
b/meta/classes-recipe/update-alternatives.bbclass
index 36a7497fec..b153e1b297 100644
--- a/meta/classes-recipe/update-alternatives.bbclass
+++ b/meta/classes-recipe/update-alternatives.bbclass
@@ -86,10 +86,10 @@ def gen_updatealternativesvardeps(d):
for p in pkgs:
for v in vars:
- for flag in sorted((d.getVarFlags("%s_%s" % (v,p)) or
{}).keys()):
+ for flag in sorted((d.getVarFlags("%s:%s" % (v,p)) or
{}).keys()):
if flag == "doc" or flag == "vardeps" or flag ==
"vardepsexp":
continue
- d.appendVar('%s_VARDEPS_%s' % (v,p), ' %s:%s' % (flag,
d.getVarFlag('%s_%s' % (v,p), flag, False)))
+ d.appendVar('%s_VARDEPS_%s' % (v,p), ' %s:%s' % (flag,
d.getVarFlag('%s:%s' % (v,p), flag, False)))
def ua_extend_depends(d):
if not 'virtual/update-alternatives' in d.getVar('PROVIDES'):
This is just found by review and I can not find any failure or fault
that is caused by this. That's why I'm trying to get some more eyes on
this and see if someone can fully understand how this is connected. With
the patch variable flags for ALTERNATIVES:${PN} is fetched instead which
should be more up to date with what we have in recipe meta data.
Is this something to send a patch for to fix old override syntax?
If yes on the first question; as we haven't found any issues with the
old code is it still needed?
Best regards,
/Peter
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#180716):
https://lists.openembedded.org/g/openembedded-core/message/180716
Mute This Topic: https://lists.openembedded.org/mt/98634942/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
