On Mon, May 08, 2023 at 02:18:57PM -0400, Denys Dmytriyenko wrote: > On Mon, May 08, 2023 at 01:13:58PM -0500, Randolph Sapp wrote: > > On 5/8/23 01:13, Peter Kjellerstedt wrote: > > >That is most certainly a good alternative. > > > > > >//Peter > > > > > >*From:*Martin Jansa <[email protected]> > > >*Sent:* den 8 maj 2023 00:20 > > >*To:* Peter Kjellerstedt <[email protected]> > > >*Cc:* [email protected]; [email protected]; [email protected]; [email protected]; > > >[email protected]; [email protected]; > > >[email protected] > > >*Subject:* Re: [OE-core][PATCH] kernel-devicetree: allow > > >specification of dtb directory > > > > > >or > > > > > >if "${@'true' if oe.types.boolean(d.getVar('KERNEL_DTBVENDORED')) > > >else 'false'} > > ><mailto:$%7b@'true'%20if%20oe.types.boolean(d.getVar('KERNEL_DTBVENDORED'))%20else%20'false'%7d>"; > > >then > > > > > >to avoid test as well (like systemd recipes is using) and I did > > >here as well in: > > > > > >https://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=e2a6da5202a6671113758f9746ddbd8141a75757 > > > > > ><https://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=e2a6da5202a6671113758f9746ddbd8141a75757> > > > > > >On Sun, May 7, 2023 at 10:49 PM Peter Kjellerstedt > > ><[email protected] <mailto:[email protected]>> > > >wrote: > > > > > > [ Outlook does not support commenting inline for HTML mails, thus > > > I’m top posting…] > > > > > > The problem is `==`, which is a bashism. POSIX shells (like dash) > > > only support `=`. When it comes to quoting, you typically want to > > > quote shell variables in tests in case they are empty. OTOH, static > > > strings without whitespace or other special characters do not need > > > quoting. So the correct way to write the if statements is: > > > > > > if [ "${KERNEL_DTBVENDORED}" = false ]; then > > > > > > (In this case it is actually a bitbake variable being quoted, but > > > unless you can guarantee it is not empty, the same rule applies.) > > > > > > //Peter
<snip> > > Ah, my bad. I need to figure out a way to get shellcheck to run on > > bash blocks in bb recipes. Would save everyone some time. I'll > > submit a V2 with your modifications Martin! > > No V2 - it already got merged into master. Moreover, due to this oversight, > it > defaults to "vendored" DT install in some builds, where bash is not the > system > shell... > > We should merge Martin's fix from his contrib tree ASAP. BTW, there are other nuisances with this change: https://patchwork.yoctoproject.org/project/ti/patch/[email protected]/ Not sure how common the use of third level in KERNEL_DTBDEST dir structure is, maybe we should add a third level generic glob to OE-Core to be safe... -- Denys
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181025): https://lists.openembedded.org/g/openembedded-core/message/181025 Mute This Topic: https://lists.openembedded.org/mt/98709532/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
