On 05/05/2023 12:50, Richard Purdie wrote:
On Fri, 2023-05-05 at 10:32 +0000, Ross Burton wrote:
On 11 Apr 2023, at 16:05, Louis Rannou via lists.openembedded.org
<[email protected]> wrote:
Create a new runner run_serial_socket which usage matches the traditional ssh
runner. Its return status is 0 when the command succeeded or 0 when it
failed. If an error is encountered, it raises an Exception.
The previous serial runner is maintained and marked as deprecated.
I absolutely love this because the existing run_serial has the most
confusing behaviour. However, we’re now duplicating a large chunk of
code: can the old function be implemented such that it calls the new
function and adapts the return values?
This has hovered in the patch queue for that reason. I also love the
idea of it, it just doesn't feel quite ready.
I've been hoping we could convert the existing users and be able to
drop the old function but I'm not managed to see how much work is left
for that.
My initial idea was indeed to change the former run_serial to use the
new run_serial_socket. The problem is that run_serial_socket can raise
exceptions which are not handled by run_serial. It's not possible to
catch them except if we create a very specific exception to this subject.
About the second question: how much work is left. serial_runner remains in:
- selftest/cases/wic.py
- selftest/cases/imagefeatures.py
- selftest/cases/overlayfs.py
- selftest/cases/runtime_test.py
- utils/dump.py
It seemed to me that fixing those is nos as easy. Further investigation
is possible, but it would be much more comfortable for me to see the
first stage validated. I would say this is a pretty good checkpoint for
saving this work while I try to fix what can be.
Thanks,
Louis
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181039):
https://lists.openembedded.org/g/openembedded-core/message/181039
Mute This Topic: https://lists.openembedded.org/mt/98199478/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
