I did not plan to add more currently. I liked this as it makes it clear the intention of a specific packagegroup to represent a feed. I don't mind dropping the class and just having our "packagefeed" packagegroups add the extra inherit. For my own knowledge, what makes a class worthwhile? Is there an expectation that a bbclass has a certain amount of functionality to it?
Thanks, Charlie On Thu, May 25, 2023 at 05:52 AM, Richard Purdie wrote: > > On Wed, 2023-05-24 at 16:55 -0500, Charlie Johnston wrote: > >> Added a new packagefeed class that contains both a >> packagegroup and the package index builds. This allows a >> one-line bitbake for a packagegroup that defines a feed >> without explicitly needing to run the package-index recipe. >> >> Signed-off-by: Charlie Johnston <[email protected]> >> --- >> meta/classes/packagefeed.bbclass | 5 +++++ >> 1 file changed, 5 insertions(+) >> create mode 100644 meta/classes/packagefeed.bbclass >> >> diff --git a/meta/classes/packagefeed.bbclass >> b/meta/classes/packagefeed.bbclass >> new file mode 100644 >> index 0000000000..b83ac54f21 >> --- /dev/null >> +++ b/meta/classes/packagefeed.bbclass >> @@ -0,0 +1,5 @@ >> +# >> +# Special case of packagegroup that includes package index builds. >> +# >> + >> +inherit packagegroup package_index > > A new class with two inherits in it doesn't really seem worthwhile to > me? Was there more you planned to add here? > > Cheers, > > Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#181716): https://lists.openembedded.org/g/openembedded-core/message/181716 Mute This Topic: https://lists.openembedded.org/mt/99118888/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
