On 5/30/23 10:18 PM, Seebs wrote:
On Tue, 30 May 2023 19:54:41 -0700
Mark Hatle <[email protected]> wrote:
- int existed = (real___xstat64(_STAT_VER, path, &buf) != -1);
+ int existed = (base_stat64(path, &buf) != -1);
Honestly, with the benefit of hindsight, I actually can't even think
why I ever thought I should be using those directly instead of through
the base_foo wrappers. Probably for a reason.
... Just in case, definitely don't merge this before testing it in
case there's some insane reason for which the base_* wrappers didn't
work here.
Ya, it's going to require some soak time in the master-next and various builds
I suspect.
...
diff --git a/ports/linux/old__x/README b/ports/linux/old__x/README
new file mode 100644
index 0000000..c94413f
--- /dev/null
+++ b/ports/linux/old__x/README
@@ -0,0 +1,28 @@
+Older glibcs contain stat functions such as:
+
+__fxstat
+__fxstatat
+__lxstat
+__xstat
+
+__fxstat64
+__fxstatat64
+__lxstat64
+__xstat64
+
+The format of these functions use the _STAT_VER defintion. New
glibc no +longer define or utilize these functions, so neither can we.
+
+We only use this subport when the functions are present, this is
checked +by with the existence of _STAT_VER.
"by with the existence"? Looks like a typo.
Ya, I forgot to clean that up, how does this look as a replacement:
Older glibcs contain xstat functions such as:
__fxstat
__fxstatat
__lxstat
__xstat
__fxstat64
__fxstatat64
__lxstat64
__xstat64
These functions are defined when the _STAT_VER is also defined.
Similarly these xmknod functions are also only defined in older glibcs:
__xmknod
__xmknodat
These functions are defind when the _MKNOD_VER is also defined.
This subport is automatically enabled with BOTH _STAT_VER and _MKNOD_VER
are present. Alternatively if the user force enables subport, it should
work as long as the symbols for these functions are still available.
Anyway, looks reasonable to me, thanks!
-s
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181986):
https://lists.openembedded.org/g/openembedded-core/message/181986
Mute This Topic: https://lists.openembedded.org/mt/99234918/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
