On Fri, Jun 9, 2023 at 5:04 AM Yu, Mingli <[email protected]>
wrote:

> +    if userpackages:
> +        d.setVar('RDEPENDS:' + d.getVar('PN') + '-user-all', '
> '.join(userpackages))
> +    mipspackage = d.getVar('PN') + "-user-mips"
> +    if mipspackage in ' '.join(userpackages):
> +        d.appendVar('RDEPENDS:' + mipspackage, ' ' + d.getVar("MLPREFIX")
> + 'bash')
>

This is just a style question, you don't need to update.

Is it worth making this conditional on ${PN}-user-mips existence? I would
just use

RDEPENDS:${PN}-user-mips = "bash"

outside this function and I don't think you would even need to explicitly
use ${MLPREFIX}. Nothing will break when ${PN}-user-mips doesn't exist
(e.g. when splitting is disabled) and it's a bit easier to read than
corresponding 3 lines in python.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#182530): 
https://lists.openembedded.org/g/openembedded-core/message/182530
Mute This Topic: https://lists.openembedded.org/mt/99421260/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to