Hi Mikko, On 6/9/23 08:52, Mikko Rapeli wrote: > Hi, > > On Fri, Jun 09, 2023 at 08:48:02AM +0200, Alexis Lothoré via > lists.openembedded.org wrote: >> From: Alexis Lothoré <[email protected]> >> >> TESTIMAGE_FAILED_QA_ARTIFACTS is defined in testimage.bbclass with a >> minimal list of files to retrieve when a test fail. By appending the ptest >> directory only in core-image-ptest.bb, thanks to multiconfig feature used >> in the recipe, only failing ptests will lead to corresponding ptest >> artifacts retrieval, instead of all ptests artifacts retrieval. >> >> Signed-off-by: Alexis Lothoré <[email protected]> >> --- >> meta/recipes-core/images/core-image-ptest.bb | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta/recipes-core/images/core-image-ptest.bb >> b/meta/recipes-core/images/core-image-ptest.bb >> index 90c26641ba3a..e1be81bb2666 100644 >> --- a/meta/recipes-core/images/core-image-ptest.bb >> +++ b/meta/recipes-core/images/core-image-ptest.bb >> @@ -28,6 +28,7 @@ QB_MEM:virtclass-mcextend-lttng-tools = "-m 4096" >> QB_MEM:virtclass-mcextend-python3-cryptography = "-m 4096" >> >> TEST_SUITES = "ping ssh parselogs ptest" >> +TESTIMAGE_FAILED_QA_ARTIFACTS:append=" ${libdir}/${MCNAME}/ptest" > > Why not += ? Also, spaces around =. > > If :append is used, bbappend in other layers can not easily override > this variable.
Good catch, thanks, I'll wait a bit for any more reviews and send a new version with this point fixed. Thanks, Alexis > > Cheers, > > -Mikko > > > > > -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#182541): https://lists.openembedded.org/g/openembedded-core/message/182541 Mute This Topic: https://lists.openembedded.org/mt/99423382/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
