On 14 Jun 2023, at 16:13, Sudip Mukherjee <[email protected]> wrote: > > Hi Ross, > > On Wed, 14 Jun 2023 at 14:53, Ross Burton <[email protected]> wrote: >> >> On 13 Jun 2023, at 21:52, Sudip Mukherjee via lists.openembedded.org >> <[email protected]> wrote: >>> # only one of openssl and gcrypt could be set >>> PACKAGECONFIG ??= "openssl" >>> @@ -41,9 +42,13 @@ do_install_ptest() { >>> install -d ${D}${PTEST_PATH}/tests >>> install -m 0755 ${S}/test-driver ${D}${PTEST_PATH}/ >>> cp -rf ${B}/tests/.libs/* ${D}${PTEST_PATH}/tests/ >>> - cp -rf ${S}/tests/mansyntax.sh ${D}${PTEST_PATH}/tests/ >>> - cp -rf ${S}/tests/ssh2.sh ${D}${PTEST_PATH}/tests/ >>> - cp -rf ${S}/tests/etc ${D}${PTEST_PATH}/tests/ >>> + cp -rf ${B}/tests/test_simple ${D}${PTEST_PATH}/tests/ >>> + cp -rf ${S}/tests/mansyntax.sh ${D}${PTEST_PATH}/tests/ >>> + cp -rf ${S}/tests/test_sshd.test ${D}${PTEST_PATH}/tests/ >>> + cp -rf ${S}/tests/openssh_server ${D}${PTEST_PATH}/tests/ >>> + cp -rf ${S}/tests/key* ${D}${PTEST_PATH}/tests/ >>> +# Makefile.inc required as test_sshd.test generates the list of test from >>> this >>> + cp -rf ${S}/tests/Makefile.inc ${D}${PTEST_PATH}/tests/ >>> mkdir -p ${D}${PTEST_PATH}/docs >>> cp -r ${S}/docs/* ${D}${PTEST_PATH}/docs/ >>> } >> >> As you’ve clearly been looking at the tests, why does the ptest support need >> the documentation? > > There is a test for manpage syntax "mansyntax.sh" which needs the > generated man pages in the docs folder. > compile_ptest_base will not fail, but actual tests will fail.
This is where I start to say that we should be trimming the tests and only running useful tests for integration purposes, not the complete upstream test suite. Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#182820): https://lists.openembedded.org/g/openembedded-core/message/182820 Mute This Topic: https://lists.openembedded.org/mt/99514759/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
