Did anything ever become of this? This is a change that at least we would appreciate.
//Peter From: Jose Quaresma <[email protected]> Sent: den 17 februari 2023 17:53 To: Peter Kjellerstedt <[email protected]> Cc: Ola x Nilsson <[email protected]>; Otavio Salvador <[email protected]>; Jose Quaresma <[email protected]>; [email protected] Subject: Re: [OE-core][PATCH 1/2] kernel-module-split: make autoload and probeconf distribution specific Hi Peter, Peter Kjellerstedt <[email protected]<mailto:[email protected]>> escreveu no dia sexta, 17/02/2023 à(s) 10:52: Wouldn’t the easiest solution be to define two variables: modulesloaddir ??= "${sysconfdir}/modules-load.d " modprobedir ??= "${sysconfdir}/modprobe.d " then in init-manager-systemd.inc you could change them to: modulesloaddir ?= "${nonarch_libdir}/modules-load.d" modprobedir ?= "${nonarch_base_libdir}/modprobe.d" Using a single prefix variable doesn’t really work since they need different paths in the latter case. I was thinking of something similar to what you suggest but only on the class: modulesloaddir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '${nonarch_libdir}', '${sysconfdir}', d)}<mailto:$%[email protected]('DISTRO_FEATURES',%20'systemd',%20'$%7bnonarch_libdir%7d',%20'$%7bsysconfdir%7d',%20d)%7d>" modprobedir ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '${nonarch_base_libdir}', '${sysconfdir}', d)}<mailto:$%[email protected]('DISTRO_FEATURES',%20'systemd',%20'$%7bnonarch_base_libdir%7d',%20'$%7bsysconfdir%7d',%20d)%7d>" Anyway your approach looks good to me too so i'll use yours, hope I can test it next week. Jose //Peter From: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> On Behalf Of Jose Quaresma Sent: den 16 februari 2023 12:08 To: Ola x Nilsson <[email protected]<mailto:[email protected]>> Cc: Otavio Salvador <[email protected]<mailto:[email protected]>>; Jose Quaresma <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> Subject: Re: [OE-core][PATCH 1/2] kernel-module-split: make autoload and probeconf distribution specific Ola x Nilsson <[email protected]<mailto:[email protected]>> escreveu no dia quinta, 16/02/2023 à(s) 08:22: On Wed, Feb 15 2023, Jose Quaresma wrote: > Hi Octavio, > > Otavio Salvador > <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>> > escreveu no dia quarta, 15/02/2023 à(s) 13:25: > Em qua., 15 de fev. de 2023 às 10:01, Jose Quaresma > <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>> > escreveu: >> >> The modules-load.d [1] - Configure kernel modules to load at boot >> should install their configuration files in /usr/lib/modules-load.d. >> >> The modprobe.d [2] - Configuration directory for modprobe >> should install their configuration files in /lib/modprobe.d >> >> [1] https://www.freedesktop.org/software/systemd/man/modules-load.d.html >> [2] >> https://www.man7.org/linux/man-pages//man5/modprobe.d.5.html<https://www.man7.org/linux/man-pages/man5/modprobe.d.5.html> >> >> Signed-off-by: Jose Quaresma >> <[email protected]<mailto:[email protected]><mailto:[email protected]<mailto:[email protected]>>> > > > Did you validate this using busybox only? Using sysv and busybox need > to be validated as well. > > Please drop this patch series because it doesn work with busybox. > > Looks like busybox don't support other path than /etc: > https://git.busybox.net/busybox/tree/modutils/modprobe.c?id=669c40ed8ebf480c95ce36135104e474e361a7e6#n658 > > So I need to implement this in another way, maybe relocating the files from > /etc only when systemd is enabled. > > Thanks for raising the issue. > > Jose > Hi, Please consider https://bugzilla.yoctoproject.org/show_bug.cgi?id=12212 as well. -- Ola x Nilsson Hi Ola, We use usermerge too but I think the weird issue here is we need to have this distribution specified only for systemd excluding busybox and sysint as pointed out by Octavio. The other solution is adding support on busybox and sysint if needed. My idea is add a prefix variable with path "/etc" by default but conditioned by systemd DISTRO_FEATURES Thanks for the bug hint. -- Best regards, José Quaresma -- Best regards, José Quaresma
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#183047): https://lists.openembedded.org/g/openembedded-core/message/183047 Mute This Topic: https://lists.openembedded.org/mt/96981851/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
