Upstream-Status: Backport 
[https://launchpad.net/debian/+source/grub2/2.02+dfsg1-20+deb10u4/]

Signed-off-by: Hitendra Prajapati <[email protected]>
---
 .../grub/files/CVE-2021-20225.patch           | 57 +++++++++++++++++++
 meta/recipes-bsp/grub/grub2.inc               |  1 +
 2 files changed, 58 insertions(+)
 create mode 100644 meta/recipes-bsp/grub/files/CVE-2021-20225.patch

diff --git a/meta/recipes-bsp/grub/files/CVE-2021-20225.patch 
b/meta/recipes-bsp/grub/files/CVE-2021-20225.patch
new file mode 100644
index 0000000000..7764f3c09d
--- /dev/null
+++ b/meta/recipes-bsp/grub/files/CVE-2021-20225.patch
@@ -0,0 +1,57 @@
+From a37238099c88de04fa43d9f15583ba33c2ec43f4 Mon Sep 17 00:00:00 2001
+From: Daniel Axtens <[email protected]>
+Date: Fri, 22 Jan 2021 16:07:29 +1100
+Subject: lib/arg: Block repeated short options that require an argument
+
+Fuzzing found the following crash:
+
+  search -hhhhhhhhhhhhhf
+
+We didn't allocate enough option space for 13 hints because the
+allocation code counts the number of discrete arguments (i.e. argc).
+However, the shortopt parsing code will happily keep processing
+a combination of short options without checking if those short
+options require an argument. This means you can easily end writing
+past the allocated option space.
+
+This fixes a OOB write which can cause heap corruption.
+
+Fixes: CVE-2021-20225
+
+Signed-off-by: Daniel Axtens <[email protected]>
+Reviewed-by: Daniel Kiper <[email protected]>
+
+Upstream-Status: Backport 
[https://launchpad.net/debian/+source/grub2/2.02+dfsg1-20+deb10u4/]
+CVE: CVE-2021-20225
+Signed-off-by: Hitendra Prajapati <[email protected]>
+---
+ grub-core/lib/arg.c | 13 +++++++++++++
+ 1 file changed, 13 insertions(+)
+
+diff --git a/grub-core/lib/arg.c b/grub-core/lib/arg.c
+index 3288609..537c5e9 100644
+--- a/grub-core/lib/arg.c
++++ b/grub-core/lib/arg.c
+@@ -299,6 +299,19 @@ grub_arg_parse (grub_extcmd_t cmd, int argc, char **argv,
+                it can have an argument value.  */
+             if (*curshort)
+               {
++                /*
++                 * Only permit further short opts if this one doesn't
++                 * require a value.
++                 */
++                if (opt->type != ARG_TYPE_NONE &&
++                    !(opt->flags & GRUB_ARG_OPTION_OPTIONAL))
++                  {
++                    grub_error (GRUB_ERR_BAD_ARGUMENT,
++                                N_("missing mandatory option for `%s'"),
++                                opt->longarg);
++                    goto fail;
++                  }
++
+                 if (parse_option (cmd, opt, 0, usr) || grub_errno)
+                   goto fail;
+               }
+-- 
+2.25.1
+
diff --git a/meta/recipes-bsp/grub/grub2.inc b/meta/recipes-bsp/grub/grub2.inc
index cb79f2212b..9da18a2adc 100644
--- a/meta/recipes-bsp/grub/grub2.inc
+++ b/meta/recipes-bsp/grub/grub2.inc
@@ -107,6 +107,7 @@ SRC_URI = "${GNU_MIRROR}/grub/grub-${PV}.tar.gz \
            file://CVE-2022-2601.patch \
            file://CVE-2022-3775.patch \
            file://CVE-2020-27749.patch \
+           file://CVE-2021-20225.patch \
            "
 SRC_URI[md5sum] = "5ce674ca6b2612d8939b9e6abed32934"
 SRC_URI[sha256sum] = 
"f10c85ae3e204dbaec39ae22fa3c5e99f0665417e91c2cb49b7e5031658ba6ea"
-- 
2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#183914): 
https://lists.openembedded.org/g/openembedded-core/message/183914
Mute This Topic: https://lists.openembedded.org/mt/99980832/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to