Hmmmm actually no, we can always pass these params to tar. Wysyłane z aplikacji Outlook dla systemu iOS<https://aka.ms/o0ukef> ________________________________ Od: Ross Burton <[email protected]> Wysłane: Wednesday, July 12, 2023 12:36:41 PM Do: Piotr Łobacz <[email protected]> DW: [email protected] <[email protected]> Temat: Re: [OE-Core][PATCH v2 3/3] package.bbclass: add support for ACLs and xattr
On 12 Jul 2023, at 00:28, Piotr Łobacz via lists.openembedded.org <[email protected]> wrote: > - # Preserve sparse files and hard links > - cmd = 'tar --exclude=./sysroot-only -cf - -C %s -p -S . | tar -xf - -C > %s' % (dest, dvar) > + # Preserve sparse files, hard links, ACLs and extended attributes > + acl = '' > + xattr = '' > + # TODO: for the moment only ipk packages are supporting ACLs and > extended attributes > + if bb.utils.contains('PACKAGE_CLASSES', 'package_ipk', True, False, d): > + acl = bb.utils.contains('DISTRO_FEATURES', 'acl', '--acls', '', d) > + xattr = bb.utils.contains('DISTRO_FEATURES', 'xattr', '--xattrs', > '', d) > + cmd = f'tar {acl} {xattr} --numeric-owner --exclude=./sysroot-only -cf - > -C {dest} -p -S . | tar {acl} {xattr} -xf - -C {dvar}' > subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT) This is still changing the behaviour for rpm packages if ipkg is enabled, which sounds like a wonderful way to introduce subtle bugs that are hard to find. Is there a problem with always passing —acls —xatttrs to tar at this step? Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#184176): https://lists.openembedded.org/g/openembedded-core/message/184176 Mute This Topic: https://lists.openembedded.org/mt/100090080/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
