This merged to master and it should not have happened. I'm sending a revert.
Alex On Tue, 11 Jul 2023 at 10:34, Changqing Li <[email protected]> wrote: > > > On 7/4/23 19:11, Ross Burton wrote: > > CAUTION: This email comes from a non Wind River email account! > > Do not click links or open attachments unless you recognize the sender and > > know the content is safe. > > > > On 30 Jun 2023, at 16:07, Alexander Kanavin via lists.openembedded.org > > <[email protected]> wrote: > >> On Fri, 30 Jun 2023 at 11:14, Changqing Li > >> <[email protected]> wrote: > >>> Remove log_lock.pid which maybe created during do_rootfs. In commit > >>> [dnf: only write the log lock to root for native dnf], > >>> native dnf changed to write log lock to root, and target dnf still > >>> use /var/log, so log_lock.pid need to be removed post do_rootfs. > >> This is not making clear why the file needs to be removed. What > >> problems occur if it is left in place? Is it supposed to be added, > >> then removed by dnf during do_rootfs, and if this doesn't happen, is > >> that a problem with dnf that needs to be fixed, rather than removing > >> the file manually after the fact? > > Absolutely. If the dnf image creation is leaving lock files then we fix > > the dnf image creation. Does dnf leave a daemon hanging around? Does it > > leave lock files when it shouldn’t? Either way, this should be in dnf or > > the image creation code itself, not a generic rootfs postcommand. > > Alex and Ross, There is no dnf daemon hanging around, you are right, > seems like an dnf bug, I will report this to dnf upstream. > > And there is no functional problem if this file is not removed, only it > may confuse user there is an useless file that is generated during > do_rootfs, it should not exit in rootfs. > > > //Changqing > > > > > Ross > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#184479): https://lists.openembedded.org/g/openembedded-core/message/184479 Mute This Topic: https://lists.openembedded.org/mt/99869451/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
