Sorry for my late response I haven't noticed your email before...

W dniu 4.08.2023 o 11:50, Jose Quaresma pisze:


Piotr Łobacz <[email protected]> escreveu no dia sexta, 4/08/2023 à(s) 09:45:

    Extend `tar` command, with additional parameters, depending
    on choosen package class and target distro features, in order
    to support ACLs and xattr.

    Additionaly set archive posix format, in order to preserve
    milliseconds in timestamps for reproducibility tests.


Looks like this adicionality set archive posix format to preserve the timestamps
is a bug fix that should be backported to previous version.
Can you split this patch in two to make it possible?
No, this posix format is not only for timestamps, it is also for usage of --acls and --xattrs. From the beginning my intention was to use --acls and --xattrs and it occurred during implementation, that gnu format is not supporting them, after that the bug with timestamps came up during the tests with reproducibility...

BR
Piotr

Jose


    Currently only `package_ipk` supports fully ACLs and xattr.

    Signed-off-by: Piotr Łobacz <[email protected]>
    ---
     meta/classes-global/sstate.bbclass | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/meta/classes-global/sstate.bbclass
    b/meta/classes-global/sstate.bbclass
    index 95373fd60a..ac890fc98e 100644
    --- a/meta/classes-global/sstate.bbclass
    +++ b/meta/classes-global/sstate.bbclass
    @@ -848,7 +848,7 @@ sstate_create_package () {
            mkdir --mode=0775 -p `dirname ${SSTATE_PKG}`
            TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`

    -       OPT="-cS"
    +       OPT="--format=posix
    ${@bb.utils.contains('DISTRO_FEATURES', 'acl', '--acls', '', d)}
    ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '--xattrs', '',
    d)} --numeric-owner -cS"
            ZSTD="zstd -${SSTATE_ZSTD_CLEVEL} -T${ZSTD_THREADS}"
            # Use pzstd if available
            if [ -x "$(command -v pzstd)" ]; then
    @@ -914,7 +914,7 @@ sstate_unpack_package () {
                    ZSTD="pzstd -p ${ZSTD_THREADS}"
            fi

    -       tar -I "$ZSTD" -xvpf ${SSTATE_PKG}
    +       tar -I "$ZSTD" --format=posix
    ${@bb.utils.contains('DISTRO_FEATURES', 'acl', '--acls', '', d)}
    ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '--xattrs', '',
    d)} -xvpf ${SSTATE_PKG}
            # update .siginfo atime on local/NFS mirror if it is a
    symbolic link
            [ ! -h ${SSTATE_PKG}.siginfo ] || [ ! -e
    ${SSTATE_PKG}.siginfo ] || touch -a ${SSTATE_PKG}.siginfo
    2>/dev/null || true
            # update each symbolic link instead of any referenced file
-- 2.34.1




--
Best regards,

José Quaresma
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186306): 
https://lists.openembedded.org/g/openembedded-core/message/186306
Mute This Topic: https://lists.openembedded.org/mt/100542722/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to