Does this mean there is a missing test for wic? Can you add one? Alex
On Fri, 18 Aug 2023 at 13:44, Markus Niebel <[email protected]> wrote: > > The kickstart parser defaults fstype to "vfat". This leads to an attempt > to create an empty file system even for regions configured with "--no-table" > if used without fstype when no --sourceparams given. > > The fix tests for fstype "none" or no_table in Partition prepare method. > This will omit the file system creation an the potential error for small > region with --no-table option. > > Signed-off-by: Markus Niebel <[email protected]> > --- > scripts/lib/wic/partition.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/lib/wic/partition.py b/scripts/lib/wic/partition.py > index bda4aef1b4..f11c393df5 100644 > --- a/scripts/lib/wic/partition.py > +++ b/scripts/lib/wic/partition.py > @@ -134,7 +134,7 @@ class Partition(): > self.update_fstab_in_rootfs = True > > if not self.source: > - if self.fstype == "none": > + if self.fstype == "none" or self.no_table: > return > if not self.size and not self.fixed_size: > raise WicError("The %s partition has a size of zero. Please " > -- > 2.25.1 > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#186365): https://lists.openembedded.org/g/openembedded-core/message/186365 Mute This Topic: https://lists.openembedded.org/mt/100818637/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
