Hello,
rust recipe does
| do_compile () {
| }
|
| rust_do_install() {
| rust_runx install
| }
|
| rust_do_install:class-nativesdk() {
| export PSEUDO_UNLOAD=1
| rust_runx install
| rust_runx install clippy
| rust_runx install rustfmt
What is the reason to run the expensive "rust_runx" in do_install() and
not in do_compile().
This:
- is unexpected... do_install is usually expected to run fast
- might interfere with different ${PARALLEL_MAKE} and ${PARALLEL_MAKEINST}
setup
- might slow down the build process because the 'class-native' variant
seems to run with active 'pseudo'
I guess it is done in this way because of
| config.set("install", "prefix", e(d.getVar("D") + d.getVar("prefix")))
where '${D}' is cleared by do_install.
Wouldn't it be better to replace this by
| config.set("install", "prefix", e(d.getVar("B") + '/_install' +
d.getVar("prefix")))
| do_compile () {
| rust_runx install
| rust_runx install clippy
| rust_runx install rustfmt
| }
|
| rust_do_install() {
| cp -a ${B}/_install ${D}
?
[adding 'rustfmt' to 'class-native' would be nice because e.g. 'bindgen'
users might expect it]
Enrico
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#187012):
https://lists.openembedded.org/g/openembedded-core/message/187012
Mute This Topic: https://lists.openembedded.org/mt/101098826/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
