I think there's expectation that the test prints at least one PASS: marker, otherwise 'bitbake -c testimage core-image-ptest-tar' is going to fail, even if running ptest-runner on the command line does not. Can you please check how this command behaves?
If it does fail, you can modify run-ptest to print FAIL: tar if something failed and PASS: tar if nothing did. './testsuite && echo "PASS: tar" || echo "FAIL" tar" is the simplest. Alex On Fri, 15 Sept 2023 at 04:26, [email protected] <[email protected]> wrote: > > From: Qiu Tingting <[email protected]> > > Add a ptest for tar. > - It is taking around 3m to execute with kvm, so added it to PTEST_SLOW. > - It contains 244 cases. > - It needs more fs space for test than normal. > - Below is parts of the run log: > START: ptest-runner > 2023-09-14T08:02 > BEGIN: /usr/lib/tar/ptest > ## ------------------------ ## > ## GNU tar 1.35 test suite. ## > ## ------------------------ ## > 1: tar version ok > 2: decompressing from stdin ok > ... > ## ------------- ## > ## Test results. ## > ## ------------- ## > > 200 tests were successful. > 44 tests were skipped. > DURATION: 188 > END: /usr/lib/tar/ptest > 2023-09-14T08:05 > STOP: ptest-runner > TOTAL: 1 FAIL: 0 > > Signed-off-by: Yan Xinkuan <[email protected]> > Signed-off-by: Qiu Tingting <[email protected]> > --- > .../distro/include/ptest-packagelists.inc | 1 + > meta/recipes-core/images/core-image-ptest.bb | 3 +++ > meta/recipes-extended/tar/tar/run-ptest | 10 +++++++ > meta/recipes-extended/tar/tar_1.35.bb | 27 +++++++++++++++++++ > 4 files changed, 41 insertions(+) > create mode 100644 meta/recipes-extended/tar/tar/run-ptest > > diff --git a/meta/conf/distro/include/ptest-packagelists.inc > b/meta/conf/distro/include/ptest-packagelists.inc > index 9160103cb0..3df7c9e405 100644 > --- a/meta/conf/distro/include/ptest-packagelists.inc > +++ b/meta/conf/distro/include/ptest-packagelists.inc > @@ -109,6 +109,7 @@ PTESTS_SLOW = "\ > python3-cryptography \ > python3 \ > strace \ > + tar \ > tcl \ > util-linux \ > valgrind \ > diff --git a/meta/recipes-core/images/core-image-ptest.bb > b/meta/recipes-core/images/core-image-ptest.bb > index b81ab7b7c8..b6f5c2fd60 100644 > --- a/meta/recipes-core/images/core-image-ptest.bb > +++ b/meta/recipes-core/images/core-image-ptest.bb > @@ -24,6 +24,9 @@ IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-mdadm = > "1524288" > IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-strace = "1024288" > IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-lttng-tools = "1524288" > > +# tar-ptest in particular needs more space > +IMAGE_ROOTFS_EXTRA_SPACE:virtclass-mcextend-tar = "1524288" > + > # ptests need more memory than standard to avoid the OOM killer > QB_MEM = "-m 1024" > QB_MEM:virtclass-mcextend-lttng-tools = "-m 4096" > diff --git a/meta/recipes-extended/tar/tar/run-ptest > b/meta/recipes-extended/tar/tar/run-ptest > new file mode 100644 > index 0000000000..ad4dd334f7 > --- /dev/null > +++ b/meta/recipes-extended/tar/tar/run-ptest > @@ -0,0 +1,10 @@ > +#!/bin/sh > + > +# Define tar test work dir > +WORKDIR=/usr/lib/tar/ptest/tests/ > + > +# Run test > +cd ${WORKDIR} > +./atconfig ./atlocal ./testsuite > + > +./testsuite > diff --git a/meta/recipes-extended/tar/tar_1.35.bb > b/meta/recipes-extended/tar/tar_1.35.bb > index 4dbd418b60..b3d22c3db9 100644 > --- a/meta/recipes-extended/tar/tar_1.35.bb > +++ b/meta/recipes-extended/tar/tar_1.35.bb > @@ -42,6 +42,33 @@ do_install:append:class-target() { > fi > } > > +# add for ptest support > +SRC_URI += " \ > + file://run-ptest \ > +" > + > +inherit ptest > + > +do_compile_ptest() { > + oe_runmake -C ${B}/gnu/ check > + oe_runmake -C ${B}/lib/ check > + oe_runmake -C ${B}/rmt/ check > + oe_runmake -C ${B}/src/ check > + oe_runmake -C ${B}/tests/ genfile checkseekhole ckmtime > +} > + > +do_install_ptest() { > + install -d ${D}${PTEST_PATH}/tests/ > + sed -i "/abs_/d" ${B}/tests/atconfig > + install --mode=755 ${B}/tests/atconfig ${D}${PTEST_PATH}/tests/ > + sed -i "s%${B}/../tar-1.34.build-aux:%%g" ${B}/tests/atlocal > + install --mode=755 ${B}/tests/atlocal ${D}${PTEST_PATH}/tests/ > + install --mode=755 ${B}/tests/genfile ${D}${PTEST_PATH}/tests/ > + install --mode=755 ${B}/tests/checkseekhole ${D}${PTEST_PATH}/tests/ > + install --mode=755 ${B}/tests/ckmtime ${D}${PTEST_PATH}/tests/ > + install --mode=755 ${S}/tests/testsuite ${D}${PTEST_PATH}/tests/ > +} > + > PACKAGES =+ "${PN}-rmt" > > FILES:${PN}-rmt = "${sbindir}/rmt*" > -- > 2.25.1 > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#187652): https://lists.openembedded.org/g/openembedded-core/message/187652 Mute This Topic: https://lists.openembedded.org/mt/101372466/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
