Hello,

contents of tarball at *1 is determined by EXTRA_DIST setting in
https://git.savannah.gnu.org/cgit/tar.git/tree/tests/Makefile.am?id=39849e9d91f477d3fb839f93cd0815d0cb3273e9#n20
which in turn refers to TESTSUITE_AT.

As of 1.35 release, TESTSUITE_AT was missing exclude17/18.at and the
following later commit adds them, fixing the issue of missing files:
https://git.savannah.gnu.org/cgit/tar.git/commit/?id=39849e9d91f477d3fb839f93cd0815d0cb3273e9
Note that the link in the commit message refers specifically to that:
https://lists.gnu.org/r/bug-tar/2023-07/msg00002.html

Commits in *3 and *4 added the files, but forgot to update TESTSUITE_AT.

Tarball in *2 has those files, because it is not actually a release
tarball, it is an archive that git automatically generates from the
git source tree when a new tag is added. That tarball should not be
used.

Rather than modify testsuite.at to exclude the two missing files,
maybe it's better to add the two missing files to the source tree in
that same patch instead? And please do refer to the commit that will
fix the issue upstream when they issue a new tarball release.

Alex


On Tue, 26 Sept 2023 at 03:18, [email protected] <[email protected]> wrote:
>
> Hi,Alex
>
> In this case, there's a fix, so please add the link to this patch:
> https://git.savannah.gnu.org/cgit/tar.git/commit/?id=39849e9d91f477d3fb839f93cd0815d0cb3273e9
>
> The bug: There is no exclude17.at or exclude18.at file in src dir, so 
> testsuite can not be compiled.
>
> | /bin/bash 
> '/Yocto/oe-core-test/build/tmp-glibc/work/core2-64-oe-linux/tar/1.35/tar-1.35/build-aux/missing'
>  autom4te --language=autotest -I ../../tar-1.35/tests testsuite.at -o 
> ../../tar-1.35/tests/testsuite.tmp | 
> m4:../../tar-1.35/tests/testsuite.at:315: cannot open `exclude17.at': No such 
> file or directory | m4:../../tar-1.35/tests/testsuite.at:316: cannot open 
> `exclude18.at': No such file or directory | autom4te: error: m4 failed with 
> exit status: 1
> Up patch only added exclude17.at and exclude18.at into Makefile, but could 
> not fix none file problem.
> So, I think it is not the fix patch.
>
> The key is that used tarball(*1) does not contain exclude17.at(*3) and 
> exclude18.at(*4).
> But another tarball(*2) contains the two files.
> I am not sure why the same version has diffrenent tarballs.
> For *1, testsuite is exist in src without compiling, so there is no problem. 
> Of course there is not any ticket or fix patch.
> In oe ptest, for adding --am-fmt, recompiling testsuite is neccessary, so the 
> problem appeared.
>
> *1: https://ftp.gnu.org/gnu/tar/tar-1.35.tar.bz2
> *2: https://git.savannah.gnu.org/cgit/tar.git/snapshot/tar-1.35.tar.gz
> *3: The following patch add exclude17.at.
> https://git.savannah.gnu.org/cgit/tar.git/commit/?id=0f0722df45ec520d0dac7c9ad7e69165e9140931
> *4: The following patch add exclude18.at. (src/names.c is changed)
> https://git.savannah.gnu.org/cgit/tar.git/commit/?id=4f814e0e4c673f86dc65a557f7e55f6b5efd1529
>
> 
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188217): 
https://lists.openembedded.org/g/openembedded-core/message/188217
Mute This Topic: https://lists.openembedded.org/mt/101569333/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to