On 03/20/2012 11:59 AM, Denys Dmytriyenko wrote: > On Tue, Mar 20, 2012 at 11:39:22AM -0700, Darren Hart wrote: >> On 03/20/2012 09:09 AM, Denys Dmytriyenko wrote: >>> On Tue, Mar 20, 2012 at 08:33:14AM -0700, Darren Hart wrote: >>>> >>>> >>>> On 03/20/2012 08:28 AM, Denys Dmytriyenko wrote: >>>>> On Tue, Mar 20, 2012 at 08:01:44AM -0700, Darren Hart wrote: >>>>>> >>>>>> >>>>>> On 03/19/2012 05:22 PM, Denys Dmytriyenko wrote: >>>>>>> From: Denys Dmytriyenko <[email protected]> >>>>>>> >>>>>>> Replace dependency on eglibc with virtual/libc >>>>>>> Pass LDFLAGS to TARGET_CC_ARCH, instead of CFLAGS as Makefile overrides >>>>>>> it >>>>>>> >>>>>>> Signed-off-by: Denys Dmytriyenko <[email protected]> >>>>>> >>>>>> Thanks Denys, >>>>>> >>>>>> Looking through the rt-tests sources I don't see TARGET_CC_ARCH >>>>>> anywhere. Have you confirmed that changes made there make their way into >>>>>> the actual build? >>>>> >>>>> Darren, >>>>> >>>>> TARGET_CC_ARCH is not an rt-tests specific variable, it's used in OE. >>>>> Although, TARGET_LDFLAGS might be more appropriate for this purpose, >>>>> historically TARGET_CC_ARCH was heavily used to pass distro LDFLAGS to >>>>> the >>>>> app's build process - grepping it would show many such cases in OE-Core >>>>> and >>>>> especially in meta-oe... >>>> >>>> OK, thanks for the context. Will you be resubmitting with TARGET_LDFLAGS? >>> >>> Nope, my bad, it's actually the other way around. From bitbake.conf: >>> >>> export LDFLAGS = "${TARGET_LDFLAGS}" >>> >>> So, appending to TARGET_CC_ARCH is the simplest way to pass flags, as >>> that's >>> embedded into $CC >>> >>> Another option would have been to call make with -e flag to let environment >>> variables override the ones in the Makefile, but that's less controlled... >>> >> >> How about the follow patch against rt-tests? Clark W. said he's fine taking a >> patch that allows such an override. Does this meet your needs? > > It does look good. Especially if it gets upstreamed! :) > > If those default CFLAGS should always be there, then you can do something > like: > > CFLAGS ?= > CFLAGS += -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include > > But that would mean there's no way to override those from outside, only add > to > them... > > Thanks for taking time to upstream the fix. I'll need to re-submit my patch > to > only do the eglibc -> virtual/libc change. >
Great, I'll submit to rt-users now then. We should be able to pull the patch into oe-core as well. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
