On Thu, 2023-10-19 at 14:32 +0200, Rasmus Villemoes via lists.openembedded.org wrote: > From: Rasmus Villemoes <[email protected]> > > Building perf without security_flags.inc being included in one's > distro results in the buildpaths warning > > WARNING: perf-1.0-r9 do_package_qa: QA Issue: File /usr/bin/trace in > package perf contains reference to TMPDIR > > because the ${DEBUG_PREFIX_MAP} does not get used. Most recipes get > that from CFLAGS, but the perf recipe explicitly unsets that. > > Now ${SELECTED_OPTIMIZATION} of course contains more than just > ${DEBUG_FLAGS}/${DEBUG_PREFIX_MAP}. For most TUs, perf's build system > adds its own optimization flags (-O6 for odd reasons), so for those > including the -O2 or -Og doesn't change anything. But looking at the > .o.cmd files show that there are some TUs which currently get built > without any -O flag. So for those adding the distro's > SELECTED_OPTIMIZATION seem to be the right thing to do. > > Signed-off-by: Rasmus Villemoes <[email protected]> > --- > meta/conf/distro/include/security_flags.inc | 1 - > meta/recipes-kernel/perf/perf.bb | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-)
The fact this works suggests perf is ignoring TARGET_CFLAGS. Is there anything in the perf build system where we should be passing in cflags we really want used? It feels like the fix is still a little fragile and we should find out how to get it to use our flags. The security_flags hack really needs to not be needed. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189456): https://lists.openembedded.org/g/openembedded-core/message/189456 Mute This Topic: https://lists.openembedded.org/mt/102058904/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
