On Tue, 2023-10-24 at 19:17 -0400, Bruce Ashfield wrote:
> On Tue, Oct 24, 2023 at 6:07 PM Khem Raj <raj.k...@gmail.com> wrote:
> > 
> > os.environ does not pass this down to runstrip() function and in
> > strip_execs() its using STRIP bitbake variable to find the strip utility
> > to use. Since there might be a trailing whitespace in KERNEL_STRIP
> > remove that otherwise python is not able to launch it.
> > e.g.
> > 
> > FileNotFoundError: [Errno 2] No such file or directory: 
> > 'riscv64-yoe-linux-strip '
> > 
> > This is more evident when STRIP and KERNEL_STRIP are different utilities
> > e.g. when using clang as default toolchain but using gcc+binutils only for
> > kernel build.
> > 
> > Signed-off-by: Khem Raj <raj.k...@gmail.com>
> > Cc: Bruce Ashfield <bruce.ashfi...@gmail.com>
> > ---
> >  meta/classes-recipe/kernel.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes-recipe/kernel.bbclass 
> > b/meta/classes-recipe/kernel.bbclass
> > index 2ec9ea2091e..16b85dbca48 100644
> > --- a/meta/classes-recipe/kernel.bbclass
> > +++ b/meta/classes-recipe/kernel.bbclass
> > @@ -336,7 +336,7 @@ kernel_do_transform_bundled_initramfs() {
> >  do_transform_bundled_initramfs[dirs] = "${B}"
> > 
> >  python do_package:prepend () {
> > -    os.environ['STRIP'] = d.getVar('KERNEL_STRIP')
> > +    d.setVar('STRIP',  d.getVar('KERNEL_STRIP').strip())
> 
> Looks fine to me.
> 
> I can't say that I know the mechanics if every setVar'd variable makes it into
> the environment to be available for the build process .. but since it is 
> working
> for you, I assume it does :)

FWIW, only variables that have their export flag set or which exported
at some point, which STRIP presumably does or is.

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189693): 
https://lists.openembedded.org/g/openembedded-core/message/189693
Mute This Topic: https://lists.openembedded.org/mt/102167569/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to