> On 8 Nov 2023, at 11:08, luca fancellu via lists.openembedded.org > <[email protected]> wrote: > > The current code in ssh.py is terminating the ssh process that > does not finish its computation in a given timeout (when timeout > is passed), the SSHCall function is returning the process error > code. > > The Openssl ssh before version 8.6_p1 is returning 0 when it is > terminated, from commit 8a9520836e71830f4fccca066dba73fea3d16bda > onwards (version >= 8.6_p1) ssh is returning 255 instead. > > So for version of ssh older than 8.6_p1 when the SSHCall time out, > the return code will be 0, meaning success, which is wrong. > > Fix this issue checking if the process has timeout (hence it's been > terminated) and checking if the returned code is 0, in that case > set it to 255 to advertise that an error occurred. > > Add a test case exercising the timeout in the SSHTest, test_ssh > test function. > > Signed-off-by: Luca Fancellu <[email protected]> > ---
Sorry, seems that I pushed twice this patch, ignore this. Cheers, Luca
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#190324): https://lists.openembedded.org/g/openembedded-core/message/190324 Mute This Topic: https://lists.openembedded.org/mt/102461629/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
