> -----Original Message-----
> From: openembedded-core@lists.openembedded.org 
> <openembedded-core@lists.openembedded.org> On Behalf Of Patchtest
> Sent: den 9 november 2023 00:10
> To: Steve Sakoman <st...@sakoman.com>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Patchtest results for [OE-core][kirkstone 5/7] cve-check: slightly 
> more verbose warning when adding the same package twice
> 
> Thank you for your submission. Patchtest identified one
> or more issues with the patch. Please see the log below for
> more information:
> 
> ---
> Testing patch 
> /home/patchtest/share/mboxes/kirkstone-5-7-cve-check-slightly-more-verbose-warning-when-adding-the-same-package-twice.patch
> 
> FAIL: test shortlog length: Edit shortlog so that it is 90 characters or less 
> (currently 91 characters) (test_mbox.TestMbox.test_shortlog_length)

I find it extremely confusing that this test refers to "shortlog".
I had to go check the code to see what it was actually testing.
It seems it is actually the "commit subject" that is being tested.

Can we please change this and other tests that refer to "shortlog" 
to either use "commit subject" (in messages) or "subject" (in 
names)?

Also, it seems the test incorrectly includes the "[kirkstone 5/7]" 
part in the tested length.

//Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#190410): 
https://lists.openembedded.org/g/openembedded-core/message/190410
Mute This Topic: https://lists.openembedded.org/mt/102475465/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to